[clang] [Clang] Instantiate functions from constant evaluation. (PR #205557)

[Corentin Jabot via cfe-commits]

================
@@ -1469,7 +1479,7 @@ class VarDecl : public DeclaratorDecl, public Redeclarable<VarDecl> {
   /// constant initializer. Should only be called once, after completing the
   /// definition of the variable.
   bool checkForConstantInitialization(
-      SmallVectorImpl<PartialDiagnosticAt> &Notes) const;
+      SmallVectorImpl<PartialDiagnosticAt> &Notes, SemaProxy *SP) const;
----------------
cor3ntin wrote:

Why are we not using pointer or reference consistently?

https://github.com/llvm/llvm-project/pull/205557