[clang] [LifetimeSafety] Improve destroyed and invalidated diagnostic notes (PR #204900)

[via cfe-commits]

iitianpushkar wrote:

Hey @NeKon69 , I have updated the patch to remove the additional AccessPath plumbing and reuse the existing getDiagSubjectDescription() helper. I also removed the scope/full-expression wording for now and updated all affected test notes.
This currently produces notes such as :
"local variable 's' is destroyed here" 
"parameter 'v' is invalidated here" 

https://github.com/llvm/llvm-project/pull/204900