[clang] [llvm] [IR] Explicitly specify target feature for module asm (PR #204548)

[via cfe-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

* 132168 tests passed
* 3019 tests skipped

All executed tests passed, but another part of the build **failed**. Click on a failure below to see the details.

<details>
<summary>[code=1] tools/mlir/lib/Target/LLVMIR/CMakeFiles/obj.MLIRTargetLLVMIRImport.dir/ModuleImport.cpp.obj</summary>

```
FAILED: [code=1] tools/mlir/lib/Target/LLVMIR/CMakeFiles/obj.MLIRTargetLLVMIRImport.dir/ModuleImport.cpp.obj
sccache C:\clang\clang-msvc\bin\clang-cl.exe  /nologo -TP -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\_work\llvm-project\llvm-project\build\tools\mlir\lib\Target\LLVMIR -IC:\_work\llvm-project\llvm-project\mlir\lib\Target\LLVMIR -IC:\_work\llvm-project\llvm-project\build\tools\mlir\include -IC:\_work\llvm-project\llvm-project\mlir\include -IC:\_work\llvm-project\llvm-project\build\include -IC:\_work\llvm-project\llvm-project\llvm\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Oi /Brepro /bigobj /permissive- -Werror=unguarded-availability-new /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported /Gw -Wundef -Werror=mismatched-tags -Werror=global-constructors /O2 /Ob2  -std:c++17 -MD -UNDEBUG /EHs-c- /GR- /showIncludes /Fotools\mlir\lib\Target\LLVMIR\CMakeFiles\obj.MLIRTargetLLVMIRImport.dir\ModuleImport.cpp.obj /Fdtools\mlir\lib\Target\LLVMIR\CMakeFiles\obj.MLIRTargetLLVMIRImport.dir\ -c -- C:\_work\llvm-project\llvm-project\mlir\lib\Target\LLVMIR\ModuleImport.cpp
C:\_work\llvm-project\llvm-project\mlir\lib\Target\LLVMIR\ModuleImport.cpp(1153,19): error: no viable conversion from 'MutableArrayRef<GlobalAsmFragment>' to 'llvm::StringRef'
1153 |   llvm::StringRef asmStr = llvmModule->getModuleInlineAsm();
|                   ^        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
C:\_work\llvm-project\llvm-project\llvm\include\llvm/ADT/StringRef.h(56,24): note: candidate constructor (the implicit copy constructor) not viable: no known conversion from 'MutableArrayRef<GlobalAsmFragment>' to 'const StringRef &' for 1st argument
56 | class LLVM_GSL_POINTER StringRef {
|                        ^~~~~~~~~
C:\_work\llvm-project\llvm-project\llvm\include\llvm/ADT/StringRef.h(56,24): note: candidate constructor (the implicit move constructor) not viable: no known conversion from 'MutableArrayRef<GlobalAsmFragment>' to 'StringRef &&' for 1st argument
56 | class LLVM_GSL_POINTER StringRef {
|                        ^~~~~~~~~
C:\_work\llvm-project\llvm-project\llvm\include\llvm/ADT/StringRef.h(91,3): note: candidate constructor not viable: no known conversion from 'MutableArrayRef<GlobalAsmFragment>' to 'std::nullptr_t' for 1st argument
91 |   StringRef(std::nullptr_t) = delete;
|   ^         ~~~~~~~~~~~~~~
C:\_work\llvm-project\llvm-project\llvm\include\llvm/ADT/StringRef.h(94,26): note: candidate constructor not viable: no known conversion from 'MutableArrayRef<GlobalAsmFragment>' to 'const char *' for 1st argument
94 |   /*implicit*/ constexpr StringRef(const char *Str LLVM_LIFETIME_BOUND)
|                          ^         ~~~~~~~~~~~~~~~
C:\_work\llvm-project\llvm-project\llvm\include\llvm/ADT/StringRef.h(103,16): note: candidate constructor not viable: no known conversion from 'MutableArrayRef<GlobalAsmFragment>' to 'const std::string &' (aka 'const basic_string<char, char_traits<char>, allocator<char>> &') for 1st argument
103 |   /*implicit*/ StringRef(const std::string &Str)
|                ^         ~~~~~~~~~~~~~~~~~~~~~~
C:\_work\llvm-project\llvm-project\llvm\include\llvm/ADT/StringRef.h(107,26): note: candidate constructor not viable: no known conversion from 'MutableArrayRef<GlobalAsmFragment>' to 'std::string_view' (aka 'basic_string_view<char>') for 1st argument
107 |   /*implicit*/ constexpr StringRef(std::string_view Str)
|                          ^         ~~~~~~~~~~~~~~~~~~~~
C:\_work\llvm-project\llvm-project\llvm\include\llvm/ADT/ArrayRef.h(275,3): note: candidate function
275 |   operator std::vector<T>() const {
|   ^
1 error generated.
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/204548