[clang] [clang][driver][darwin] DarwinSDKInfo doesn't match sufficiently modified triples, doesn't warn for unsupported architectures (PR #204061)

[Steven Wu via cfe-commits]

================
@@ -195,6 +273,8 @@ DarwinSDKInfo::parseDarwinSDKSettingsJSON(std::string FilePath,
   PlatformInfoStorageType PlatformInfos =
       parsePlatformInfos(*Obj, XcodePlatform, OSAndEnvironment.first,
                          OSAndEnvironment.second, *Version);
+  if (PlatformInfos.empty())
----------------
cachemeifyoucan wrote:

Same observation as I had. But both SDKSettings.json and some legacy targets are all user inputs coming outside of compiler. We should not use assertion to prevent errors from compiler inputs. We should have proper diagnostics. 

https://github.com/llvm/llvm-project/pull/204061