[clang] [clang][ExprConst] Add `EvalStatus::DiagEmitted` flag (PR #203838)

[via cfe-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Linux-->
# :penguin: Linux x64 Test Results

* 88181 tests passed
* 1658 tests skipped
* 4 tests failed

## Failed Tests
(click on a test name to see its output)

### Clang
<details>
<summary>Clang.AST/ByteCode/functions.cpp</summary>

```
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang -cc1 -internal-isystem /home/gha/actions-runner/_work/llvm-project/llvm-project/build/lib/clang/23/include -nostdsysteminc            -pedantic -verify=expected,both /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/AST/ByteCode/functions.cpp -fexperimental-new-constant-interpreter -DINTERP
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang -cc1 -internal-isystem /home/gha/actions-runner/_work/llvm-project/llvm-project/build/lib/clang/23/include -nostdsysteminc -pedantic -verify=expected,both /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/AST/ByteCode/functions.cpp -fexperimental-new-constant-interpreter -DINTERP
# .---command stderr------------
# | error: diagnostics with 'error' severity seen but not expected: 
# |   File /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/AST/ByteCode/functions.cpp Line 672: constexpr variable 'test4' must be initialized by a constant expression
# | 1 error generated.
# `-----------------------------
# error: command failed with exit status: 1

--

```
</details>
<details>
<summary>Clang.SemaCXX/builtin-assume-aligned.cpp</summary>

```
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang -cc1 -internal-isystem /home/gha/actions-runner/_work/llvm-project/llvm-project/build/lib/clang/23/include -nostdsysteminc -fsyntax-only -verify -std=c++11 -triple x86_64-linux-gnu /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/SemaCXX/builtin-assume-aligned.cpp
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang -cc1 -internal-isystem /home/gha/actions-runner/_work/llvm-project/llvm-project/build/lib/clang/23/include -nostdsysteminc -fsyntax-only -verify -std=c++11 -triple x86_64-linux-gnu /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/SemaCXX/builtin-assume-aligned.cpp
# .---command stderr------------
# | error: 'expected-error' diagnostics seen but not expected: 
# |   File /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/SemaCXX/builtin-assume-aligned.cpp Line 41: constexpr variable 'x' must be initialized by a constant expression
# |   File /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/SemaCXX/builtin-assume-aligned.cpp Line 48: constexpr variable 's3' must be initialized by a constant expression
# | error: 'expected-note' diagnostics expected but not seen: 
# |   File /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/SemaCXX/builtin-assume-aligned.cpp Line 44 (directive at /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/SemaCXX/builtin-assume-aligned.cpp:43): value of the aligned pointer (255) is not a multiple of the asserted 32 bytes
# |   File /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/SemaCXX/builtin-assume-aligned.cpp Line 47 (directive at /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/SemaCXX/builtin-assume-aligned.cpp:46): value of the aligned pointer (250) is not a multiple of the asserted 32 bytes
# | error: 'expected-note' diagnostics seen but not expected: 
# |   File /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/SemaCXX/builtin-assume-aligned.cpp Line 44: initializer of 'x' is not a constant expression
# |   File /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/SemaCXX/builtin-assume-aligned.cpp Line 41: declared here
# |   File /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/SemaCXX/builtin-assume-aligned.cpp Line 47: initializer of 'x' is not a constant expression
# |   File /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/SemaCXX/builtin-assume-aligned.cpp Line 41: declared here
# |   File /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/SemaCXX/builtin-assume-aligned.cpp Line 48: initializer of 'x' is not a constant expression
# |   File /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/SemaCXX/builtin-assume-aligned.cpp Line 41: declared here
# | 10 errors generated.
# `-----------------------------
# error: command failed with exit status: 1

--

```
</details>
<details>
<summary>Clang.SemaCXX/constant-expression-cxx11.cpp</summary>

```
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang -cc1 -internal-isystem /home/gha/actions-runner/_work/llvm-project/llvm-project/build/lib/clang/23/include -nostdsysteminc -std=c++23 -isystem /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/SemaCXX/Inputs -fsyntax-only -verify=expected,cxx20_23,cxx23              -triple x86_64-linux -Wno-string-plus-int -Wno-pointer-arith -Wno-zero-length-array -Wno-c99-designator -fcxx-exceptions -pedantic /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/SemaCXX/constant-expression-cxx11.cpp -Wno-comment -Wno-tautological-pointer-compare -Wno-bool-conversion
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang -cc1 -internal-isystem /home/gha/actions-runner/_work/llvm-project/llvm-project/build/lib/clang/23/include -nostdsysteminc -std=c++23 -isystem /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/SemaCXX/Inputs -fsyntax-only -verify=expected,cxx20_23,cxx23 -triple x86_64-linux -Wno-string-plus-int -Wno-pointer-arith -Wno-zero-length-array -Wno-c99-designator -fcxx-exceptions -pedantic /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/SemaCXX/constant-expression-cxx11.cpp -Wno-comment -Wno-tautological-pointer-compare -Wno-bool-conversion
# .---command stderr------------
# | error: diagnostics with 'error' severity seen but not expected: 
# |   File /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/SemaCXX/constant-expression-cxx11.cpp Line 1597: constexpr variable 'm' must be initialized by a constant expression
# |   File /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/SemaCXX/constant-expression-cxx11.cpp Line 1598: static assertion expression is not an integral constant expression
# | error: diagnostics with 'note' severity seen but not expected: 
# |   File /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/SemaCXX/constant-expression-cxx11.cpp Line 1598: initializer of 'm' is not a constant expression
# |   File /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/SemaCXX/constant-expression-cxx11.cpp Line 1597: declared here
# | 4 errors generated.
# `-----------------------------
# error: command failed with exit status: 1

--

```
</details>

### Clang-Unit
<details>
<summary>Clang-Unit._/AllClangUnitTests/Decl/CleansUpAPValues</summary>

```
Script:
--
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/unittests/./AllClangUnitTests --gtest_filter=Decl.CleansUpAPValues
--
/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/unittests/AST/DeclTest.cpp:64
Value of: runToolOnCodeWithArgs( Factory->create(), "struct X { int a; }; constexpr X x = { 42 };" "union Y { constexpr Y(int a) : a(a) {} int a; }; constexpr Y y = { 42 };" "constexpr int z[2] = { 42, 43 };" "constexpr int __attribute__((vector_size(16))) v1 = {};" "\n#ifdef __SIZEOF_INT128__\n" "constexpr __uint128_t large_int = 0xffffffffffffffff;" "constexpr __uint128_t small_int = 1;" "\n#endif\n" "constexpr double d1 = 42.42;" "constexpr long double d2 = 42.42;" "constexpr _Complex long double c1 = 42.0i;" "constexpr _Complex long double c2 = 42.0;" "template<int N> struct A : A<N-1> {};" "template<> struct A<0> { int n; }; A<50> a;" "constexpr int &r = a.n;" "constexpr int A<50>::*p = &A<50>::n;" "void f() { foo: bar: constexpr int k = __builtin_constant_p(0) ?" "                         (char*)&&foo - (char*)&&bar : 0; }", Args)
  Actual: false
Expected: true


```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/203838