[clang] [clang-tools-extra] [clangd] Optionally Suppress Types in Completions (PR #200103)

[Ashley Coleman via cfe-commits]

================
@@ -1029,7 +1031,9 @@ struct CompletionRecorder : public CodeCompleteConsumer {
     // CodeCompletionResult doesn't seem to be const-correct. We own it, anyway.
     return const_cast<CodeCompletionResult &>(R).CreateCodeCompletionString(
         *CCSema, CCContext, *CCAllocator, CCTUInfo,
-        /*IncludeBriefComments=*/false);
+        /*IncludeBriefComments=*/false,
+        /*SuppressFuncParamType=*/Opts.ArgumentLists ==
----------------
V-FEXrt wrote:

FYI I'm going to be out of office until next Tuesday so I probably wont be able to respond until then.

That said, after reading more of the CCS API I am inclined to say that adding another union value (and updating return types) is the right move. There will be some churn but after looking at it closer it seems like its not a crazy amount of churn. Sorry for the flip-flopping!

https://github.com/llvm/llvm-project/pull/200103