[clang] 976282b - clang: Remove BoundArch assert in AMDGPUToolChain::addClangTargetOptions (#203060)
via cfe-commits
cfe-commits at lists.llvm.org
Wed Jun 10 10:51:58 PDT 2026
Author: Matt Arsenault
Date: 2026-06-10T19:51:53+02:00
New Revision: 976282b5bd3c7aa628c12edaad30b17e07817bc4
URL: https://github.com/llvm/llvm-project/commit/976282b5bd3c7aa628c12edaad30b17e07817bc4
DIFF: https://github.com/llvm/llvm-project/commit/976282b5bd3c7aa628c12edaad30b17e07817bc4.diff
LOG: clang: Remove BoundArch assert in AMDGPUToolChain::addClangTargetOptions (#203060)
This was assuming that the offload languages use a subclass, and
only OpenCL hits the AMDGPUToolChain base class. Flang violates this,
and passes in the wrong values. Delete the assert for now.
Added:
Modified:
clang/lib/Driver/ToolChains/AMDGPU.cpp
Removed:
################################################################################
diff --git a/clang/lib/Driver/ToolChains/AMDGPU.cpp b/clang/lib/Driver/ToolChains/AMDGPU.cpp
index 47df326fca9be..4320d1480be61 100644
--- a/clang/lib/Driver/ToolChains/AMDGPU.cpp
+++ b/clang/lib/Driver/ToolChains/AMDGPU.cpp
@@ -841,9 +841,6 @@ ROCMToolChain::ROCMToolChain(const Driver &D, const llvm::Triple &Triple,
void AMDGPUToolChain::addClangTargetOptions(
const llvm::opt::ArgList &DriverArgs, llvm::opt::ArgStringList &CC1Args,
llvm::StringRef BoundArch, Action::OffloadKind DeviceOffloadingKind) const {
- assert(DeviceOffloadingKind == Action::OFK_None && BoundArch.empty() &&
- "this toolchain is for non-offloading cases");
-
// Default to "hidden" visibility, as object level linking will not be
// supported for the foreseeable future.
// TODO: remove the SPIR-V bypass once it can encode (hidden) visibility.
More information about the cfe-commits
mailing list