[clang] [clang] restore Alloca from CreateAggTemp (PR #202978)
Jameson Nash via cfe-commits
cfe-commits at lists.llvm.org
Wed Jun 10 06:56:52 PDT 2026
https://github.com/vtjnash created https://github.com/llvm/llvm-project/pull/202978
Noticed in post-review feedback on #200427
>From 15e2935488b606c8bd34d54dd73163dd43f9dcf6 Mon Sep 17 00:00:00 2001
From: Jameson Nash <vtjnash at gmail.com>
Date: Wed, 10 Jun 2026 13:55:33 +0000
Subject: [PATCH] [clang] restore Alloca from CreateAggTemp
Noticed in post-review feedback on #200427
---
clang/lib/CodeGen/CodeGenFunction.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/clang/lib/CodeGen/CodeGenFunction.h b/clang/lib/CodeGen/CodeGenFunction.h
index 6bb9f285ebcfd..aeace0d789a61 100644
--- a/clang/lib/CodeGen/CodeGenFunction.h
+++ b/clang/lib/CodeGen/CodeGenFunction.h
@@ -2962,9 +2962,7 @@ class CodeGenFunction : public CodeGenTypeCache {
/// aggregate type.
AggValueSlot CreateAggTemp(QualType T, const Twine &Name = "tmp",
RawAddress *Alloca = nullptr) {
- RawAddress Addr = CreateMemTemp(T, Name);
- if (Alloca)
- *Alloca = Addr;
+ RawAddress Addr = CreateMemTemp(T, Name, Alloca);
return AggValueSlot::forAddr(
Addr, T.getQualifiers(), AggValueSlot::IsNotDestructed,
AggValueSlot::DoesNotNeedGCBarriers, AggValueSlot::IsNotAliased,
More information about the cfe-commits
mailing list