[clang] fix(clang): Fix miscompile for string literals. (PR #202837)

via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 9 20:02:35 PDT 2026


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- clang/lib/Sema/SemaTemplateInstantiate.cpp clang/test/SemaTemplate/instantiate-init.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/lib/Sema/SemaTemplateInstantiate.cpp b/clang/lib/Sema/SemaTemplateInstantiate.cpp
index ee9d986bc..cede8fc25 100644
--- a/clang/lib/Sema/SemaTemplateInstantiate.cpp
+++ b/clang/lib/Sema/SemaTemplateInstantiate.cpp
@@ -1917,11 +1917,9 @@ TemplateInstantiator::TransformPredefinedExpr(PredefinedExpr *E) {
   return getSema().BuildPredefinedExpr(E->getLocation(), E->getIdentKind());
 }
 
-ExprResult
-TemplateInstantiator::TransformStringLiteral(StringLiteral *E) {
+ExprResult TemplateInstantiator::TransformStringLiteral(StringLiteral *E) {
   return StringLiteral::Create(
-      SemaRef.Context, E->getBytes(), E->getKind(), E->isPascal(),
-      E->getType(),
+      SemaRef.Context, E->getBytes(), E->getKind(), E->isPascal(), E->getType(),
       llvm::ArrayRef<SourceLocation>(E->tokloc_begin(), E->tokloc_end()));
 }
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/202837


More information about the cfe-commits mailing list