[clang] [llvm] [HLSL] Set visibility of cbuffer global variables to internal (2nd attempt) (PR #202745)

via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 9 12:47:37 PDT 2026


github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Linux-->
# :penguin: Linux x64 Test Results

The build failed before running any tests. Click on a failure below to see the details.

<details>
<summary>lib/Frontend/HLSL/CMakeFiles/LLVMFrontendHLSL.dir/CBuffer.cpp.o</summary>

```
FAILED: lib/Frontend/HLSL/CMakeFiles/LLVMFrontendHLSL.dir/CBuffer.cpp.o
sccache /opt/llvm/bin/clang++ -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_USE_CXX11_ABI=1 -D_GNU_SOURCE -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/lib/Frontend/HLSL -I/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Frontend/HLSL -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include -gmlt -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++17 -UNDEBUG -fno-exceptions -funwind-tables -fno-rtti -MD -MT lib/Frontend/HLSL/CMakeFiles/LLVMFrontendHLSL.dir/CBuffer.cpp.o -MF lib/Frontend/HLSL/CMakeFiles/LLVMFrontendHLSL.dir/CBuffer.cpp.o.d -o lib/Frontend/HLSL/CMakeFiles/LLVMFrontendHLSL.dir/CBuffer.cpp.o -c /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Frontend/HLSL/CBuffer.cpp
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Frontend/HLSL/CBuffer.cpp:84:19: error: unknown type name 'ConstantArray'; did you mean 'ConstantData'?
84 |   auto *CA = cast<ConstantArray>(UsedListGV->getInitializer());
|                   ^~~~~~~~~~~~~
|                   ConstantData
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include/llvm/IR/Value.h:36:7: note: 'ConstantData' declared here
36 | class ConstantData;
|       ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Frontend/HLSL/CBuffer.cpp:86:20: error: member access into incomplete type 'llvm::ConstantData'
86 |   for (Use &Op : CA->operands()) {
|                    ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include/llvm/IR/Value.h:36:7: note: forward declaration of 'llvm::ConstantData'
36 | class ConstantData;
|       ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Frontend/HLSL/CBuffer.cpp:99:9: error: use of undeclared identifier 'ConstantArray'; did you mean 'ConstantData'?
99 |         ConstantArray::get(ATy, NewInit), "", UsedListGV,
|         ^~~~~~~~~~~~~
|         ConstantData
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include/llvm/IR/Value.h:36:7: note: 'ConstantData' declared here
36 | class ConstantData;
|       ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Frontend/HLSL/CBuffer.cpp:99:9: error: incomplete type 'llvm::ConstantData' named in nested name specifier
99 |         ConstantArray::get(ATy, NewInit), "", UsedListGV,
|         ^~~~~~~~~~~~~~~
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include/llvm/IR/Value.h:36:7: note: forward declaration of 'llvm::ConstantData'
36 | class ConstantData;
|       ^
In file included from /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Frontend/HLSL/CBuffer.cpp:9:
In file included from /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include/llvm/Frontend/HLSL/CBuffer.h:17:
In file included from /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include/llvm/IR/DataLayout.h:28:
In file included from /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include/llvm/IR/DerivedTypes.h:23:
In file included from /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include/llvm/IR/Type.h:18:
In file included from /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include/llvm/Support/CBindingWrapping.h:17:
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include/llvm/Support/Casting.h:64:53: error: incomplete type 'llvm::ConstantData' named in nested name specifier
64 |   static inline bool doit(const From &Val) { return To::classof(&Val); }
|                                                     ^~~~
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include/llvm/Support/Casting.h:110:32: note: in instantiation of member function 'llvm::isa_impl<llvm::ConstantData, llvm::Constant>::doit' requested here
110 |     return isa_impl<To, From>::doit(*Val);
|                                ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include/llvm/Support/Casting.h:137:37: note: in instantiation of member function 'llvm::isa_impl_cl<llvm::ConstantData, const llvm::Constant *>::doit' requested here
137 |     return isa_impl_cl<To, FromTy>::doit(Val);
|                                     ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include/llvm/Support/Casting.h:129:9: note: in instantiation of member function 'llvm::isa_impl_wrap<llvm::ConstantData, const llvm::Constant *, const llvm::Constant *>::doit' requested here
129 |         doit(simplify_type<const From>::getSimplifiedValue(Val));
|         ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include/llvm/Support/Casting.h:257:58: note: in instantiation of member function 'llvm::isa_impl_wrap<llvm::ConstantData, const llvm::Constant *const, const llvm::Constant *>::doit' requested here
257 |         typename simplify_type<const From>::SimpleType>::doit(f);
|                                                          ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include/llvm/Support/Casting.h:509:28: note: in instantiation of member function 'llvm::CastIsPossible<llvm::ConstantData, const llvm::Constant *>::isPossible' requested here
509 |     return SimplifiedSelf::isPossible(
|                            ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include/llvm/Support/Casting.h:548:37: note: in instantiation of member function 'llvm::CastInfo<llvm::ConstantData, llvm::Constant *const>::isPossible' requested here
548 |   return (CastInfo<To, const From>::isPossible(Val) || ...);
|                                     ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include/llvm/Support/Casting.h:572:10: note: in instantiation of function template specialization 'llvm::isa<llvm::ConstantData, llvm::Constant *>' requested here
572 |   assert(isa<To>(Val) && "cast<Ty>() argument of incompatible type!");
|          ^
/usr/include/assert.h:103:27: note: expanded from macro 'assert'
103 |      (static_cast <bool> (expr)                                         \
|                           ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include/llvm/IR/Value.h:36:7: note: forward declaration of 'llvm::ConstantData'
36 | class ConstantData;
|       ^
5 errors generated.
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/202745


More information about the cfe-commits mailing list