[clang] [analyzer] Disable lock order reversal check by default in PthreadLoc… (PR #202452)

[Balázs Benics via cfe-commits]

================
@@ -742,8 +746,21 @@ bool ento::shouldRegisterPthreadLockBase(const CheckerManager &mgr) { return tru
                                                                                \
   bool ento::shouldRegister##name(const CheckerManager &mgr) { return true; }
 
-REGISTER_CHECKER(PthreadLockChecker)
 REGISTER_CHECKER(FuchsiaLockChecker)
 REGISTER_CHECKER(C11LockChecker)
 
 #undef REGISTER_CHECKER
+
+void ento::registerPthreadLockChecker(CheckerManager &mgr) {
+  PthreadLockChecker *checker = mgr.getChecker<PthreadLockChecker>();
+  checker->ChecksEnabled[PthreadLockChecker::CK_PthreadLockChecker] = true;
+  checker->CheckNames[PthreadLockChecker::CK_PthreadLockChecker] =
+      mgr.getCurrentCheckerName();
+  checker->WarnOnLockOrderReversal =
+      mgr.getAnalyzerOptions().getCheckerBooleanOption(
+          mgr.getCurrentCheckerName(), "WarnOnLockOrderReversal");
+}
+
+bool ento::shouldRegisterPthreadLockChecker(const CheckerManager &mgr) {
----------------
steakhal wrote:

```suggestion
bool ento::shouldRegisterPthreadLockChecker(const CheckerManager &) {
```

https://github.com/llvm/llvm-project/pull/202452