[clang] [clang][analyzer] Detect use-after-move for 3-arg std::move (PR #196602)

[Balázs Benics via cfe-commits]

================
@@ -494,6 +507,77 @@ void MoveChecker::checkPostCall(const CallEvent &Call,
   assert(!C.isDifferent() && "Should not have made transitions on this path!");
 }
 
+bool MoveChecker::evalCall(const CallEvent &Call, CheckerContext &C) const {
+
+  const auto *CE = dyn_cast_if_present<CallExpr>(Call.getOriginExpr());
+  if (!CE)
+    return false;
+
+  ProgramStateRef State = C.getState();
+
+  if (!StdMoveCall.matches(Call))
+    return false;
+
+  const auto *POS = getIteratorPosition(State, Call.getArgSVal(0));
+  if (!POS)
+    return false;
+
+  const MemRegion *ContainerRegion = POS->getContainer();
+  if (!ContainerRegion)
+    return false;
+
+  const auto *TypedRegion =
+      dyn_cast_if_present<TypedValueRegion>(ContainerRegion);
+  if (!TypedRegion)
+    return false;
+
+  QualType ObjTy = TypedRegion->getValueType();
+
+  const auto *RD = ObjTy->getAsCXXRecordDecl();
+  if (!RD)
+    return false;
+
+  ObjectKind OK = classifyObject(State, ContainerRegion, RD);
+
+  // FIXME: Also apply getIteratorPosition from IteratorModeling to recover the
+  // destination region instead of doing AST pattern matching.
----------------
steakhal wrote:

You are already using `getIteratorPosition` at the other function. Why not also here?

https://github.com/llvm/llvm-project/pull/196602