[clang] [clang-repl] Fix Value's move ctor releasing storage on construction (PR #200888)

[via cfe-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Linux-->
# :penguin: Linux x64 Test Results

* 36987 tests passed
* 582 tests skipped

All executed tests passed, but another part of the build **failed**. Click on a failure below to see the details.

<details>
<summary>tools/clang/unittests/Interpreter/CMakeFiles/ClangReplInterpreterTests.dir/InterpreterTest.cpp.o</summary>

```
FAILED: tools/clang/unittests/Interpreter/CMakeFiles/ClangReplInterpreterTests.dir/InterpreterTest.cpp.o
sccache /opt/llvm/bin/clang++ -DLLVM_BUILD_STATIC -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_USE_CXX11_ABI=1 -D_GNU_SOURCE -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/unittests/Interpreter -I/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/unittests/Interpreter -I/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/third-party/unittest/googletest/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/third-party/unittest/googlemock/include -gmlt -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -Wno-nested-anon-types -O3 -DNDEBUG -std=c++17 -UNDEBUG -Wno-variadic-macros -Wno-gnu-zero-variadic-macro-arguments -fno-exceptions -funwind-tables -fno-rtti -Wno-suggest-override -MD -MT tools/clang/unittests/Interpreter/CMakeFiles/ClangReplInterpreterTests.dir/InterpreterTest.cpp.o -MF tools/clang/unittests/Interpreter/CMakeFiles/ClangReplInterpreterTests.dir/InterpreterTest.cpp.o.d -o tools/clang/unittests/Interpreter/CMakeFiles/ClangReplInterpreterTests.dir/InterpreterTest.cpp.o -c /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/unittests/Interpreter/InterpreterTest.cpp
/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/unittests/Interpreter/InterpreterTest.cpp:458:1: error: static data member 'test_info_' not allowed in local class 'InterpreterTest_ValueMoveSemantics_Test'
458 | TEST_F(InterpreterTest, ValueMoveSemantics) {
| ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/third-party/unittest/googletest/include/gtest/gtest.h:2208:41: note: expanded from macro 'TEST_F'
2208 | #define TEST_F(test_fixture, test_name) GTEST_TEST_F(test_fixture, test_name)
|                                         ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/third-party/unittest/googletest/include/gtest/gtest.h:2205:3: note: expanded from macro 'GTEST_TEST_F'
2205 |   GTEST_TEST_(test_fixture, test_name, test_fixture, \
|   ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/third-party/unittest/googletest/include/gtest/internal/gtest-internal.h:1544:39: note: expanded from macro 'GTEST_TEST_'
1544 |     static ::testing::TestInfo* const test_info_ GTEST_ATTRIBUTE_UNUSED_;      \
|                                       ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/unittests/Interpreter/InterpreterTest.cpp:458:45: error: function definition is not allowed here
458 | TEST_F(InterpreterTest, ValueMoveSemantics) {
|                                             ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/unittests/Interpreter/InterpreterTest.cpp:505:1: error: static data member 'test_info_' not allowed in local class 'InterpreterTest_TranslationUnit_CanonicalDecl_Test'
505 | TEST_F(InterpreterTest, TranslationUnit_CanonicalDecl) {
| ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/third-party/unittest/googletest/include/gtest/gtest.h:2208:41: note: expanded from macro 'TEST_F'
2208 | #define TEST_F(test_fixture, test_name) GTEST_TEST_F(test_fixture, test_name)
|                                         ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/third-party/unittest/googletest/include/gtest/gtest.h:2205:3: note: expanded from macro 'GTEST_TEST_F'
2205 |   GTEST_TEST_(test_fixture, test_name, test_fixture, \
|   ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/third-party/unittest/googletest/include/gtest/internal/gtest-internal.h:1544:39: note: expanded from macro 'GTEST_TEST_'
1544 |     static ::testing::TestInfo* const test_info_ GTEST_ATTRIBUTE_UNUSED_;      \
|                                       ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/unittests/Interpreter/InterpreterTest.cpp:505:56: error: function definition is not allowed here
505 | TEST_F(InterpreterTest, TranslationUnit_CanonicalDecl) {
|                                                        ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/unittests/Interpreter/InterpreterTest.cpp:527:29: error: expected '}'
527 | } // end anonymous namespace
|                             ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/unittests/Interpreter/InterpreterTest.cpp:37:11: note: to match this '{'
37 | namespace {
|           ^
5 errors generated.
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/200888