[clang] [llvm] [clang] -funique-internal-linkage-names should not be applied to asm label (PR #202004)
via cfe-commits
cfe-commits at lists.llvm.org
Fri Jun 5 22:15:07 PDT 2026
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp,c -- clang/lib/CodeGen/CodeGenModule.cpp clang/test/CodeGen/unique-internal-linkage-names.c clang/test/CodeGen/unique-internal-linkage-names.cpp llvm/lib/CodeGen/CodeGenPrepare.cpp llvm/lib/CodeGen/MachineSink.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/llvm/lib/CodeGen/MachineSink.cpp b/llvm/lib/CodeGen/MachineSink.cpp
index 28d127e43..32ad39d12 100644
--- a/llvm/lib/CodeGen/MachineSink.cpp
+++ b/llvm/lib/CodeGen/MachineSink.cpp
@@ -2172,8 +2172,7 @@ bool MachineSinking::sinkDiamondLoadToUsers(MachineInstr &MI,
// the top).
// Also reject odd sink targets.
for (MachineBasicBlock *S : UsingBlocks) {
- if (S->pred_size() != 1 || S->isEHPad() ||
- S->isInlineAsmBrIndirectTarget())
+ if (S->pred_size() != 1 || S->isEHPad() || S->isInlineAsmBrIndirectTarget())
return false;
if (MachineCycle *C = CI->getCycle(S))
if (!C->isReducible() || C->getHeader() == S)
``````````
</details>
https://github.com/llvm/llvm-project/pull/202004
More information about the cfe-commits
mailing list