erichkeane wrote: I'll need another pass at this, as you missed quite a few of the things I suggested I think. ALso, the `!!` pattern is an anti-pattern for conversions, particularly when we already have a bool conversion for that type. https://github.com/llvm/llvm-project/pull/199790