[clang-tools-extra] [clang-tidy] Fix false positive in bugprone-use-after-move with std::forward on derived classes (PR #199905)

[via cfe-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- clang-tools-extra/test/clang-tidy/checkers/bugprone/use-after-move-forward-derived.cpp clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp b/clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp
index 301b943a8..1570c3a39 100644
--- a/clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp
+++ b/clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp
@@ -644,9 +644,8 @@ void UseAfterMoveCheck::check(const MatchFinder::MatchResult &Result) {
   if (!MovedAs && CallMove && CallMove->getNumArgs() > 0) {
     if (const auto *ArgCast =
             dyn_cast<ImplicitCastExpr>(CallMove->getArg(0)->IgnoreParens())) {
-      if (ArgCast->getCastKind() == CK_DerivedToBase) {
+      if (ArgCast->getCastKind() == CK_DerivedToBase)
         MovedAs = ArgCast->getType()->getAsCXXRecordDecl();
-      }
     }
   }
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/199905