[clang] [Clang][CodeGen] Track EH cleanup depth for guarded init and pop correctly (PR #199508)

[via cfe-commits]

mkovacevic99 wrote:

> If I'm reading the patch correctly, the issue is that EmitCXXGlobalVarDeclInit() is pushing a cleanup block, and not popping it? Did you look into fixing this somewhere inside EmitCXXGlobalVarDeclInit(), closer to where we construct the cleanups in question?

EmitCXXGlobalVarDeclInit is pushing cleanups (it can emit more than one) and before in EmitGuardedInit it just popped one, the way I understood it the popping logic is in EmitGuardedInit and EmitCXXGlobalVarDeclInit is not supposed to pop them. EmitCXXGlobalVarDeclInit emitted all the cleanup blocks as it should so I don't think I should change that logic.

https://github.com/llvm/llvm-project/pull/199508