[clang] [CIR][AArch64] Upstream vector-shift-right-and-insert NEON builtins (PR #196776)

[Andrzej Warzyński via cfe-commits]

================
@@ -369,12 +427,23 @@ static mlir::Value emitCommonNeonSISDBuiltinExpr(
   case NEON::BI__builtin_neon_vmaxv_f32:
   case NEON::BI__builtin_neon_vmaxvq_f32:
   case NEON::BI__builtin_neon_vmaxvq_f64:
-    return emitNeonCall(cgf.cgm, cgf.getBuilder(),
-                        {cgf.convertType(expr->getArg(0)->getType())}, ops,
-                        llvmIntrName, cgf.convertType(expr->getType()), loc);
+  case NEON::BI__builtin_neon_vsrid_n_s64:
+  case NEON::BI__builtin_neon_vsrid_n_u64:
+    break;
   }
 
-  return nullptr;
+  CIRGenBuilderTy &builder = cgf.getBuilder();
+  mlir::Type argTy = cgf.convertType(expr->getArg(0)->getType());
----------------
banach-space wrote:

I suggest being a bit more explicit in naming (and also making the intent clearer) :)
```suggestion
  mlir::Type arg0Ty = cgf.convertType(expr->getArg(0)->getType());
```

https://github.com/llvm/llvm-project/pull/196776