[clang] [CIR] Fix union RecordType::getTypeSizeInBits to return bits (PR #191516)

Erich Keane via cfe-commits cfe-commits at lists.llvm.org
Fri May 22 08:40:20 PDT 2026


================
@@ -378,8 +378,12 @@ PointerType::getABIAlignment(const ::mlir::DataLayout &dataLayout,
 llvm::TypeSize
 RecordType::getTypeSizeInBits(const mlir::DataLayout &dataLayout,
                               mlir::DataLayoutEntryListRef params) const {
-  if (isUnion())
-    return dataLayout.getTypeSize(getLargestMember(dataLayout));
+  if (isUnion()) {
+    mlir::Type largest = getLargestMember(dataLayout);
+    if (!largest)
+      return llvm::TypeSize::getFixed(0);
----------------
erichkeane wrote:

_I_ think so, which is why this looks odd :)  Presumably this should return '8' (or more correctly, just the size of 'char').

https://github.com/llvm/llvm-project/pull/191516


More information about the cfe-commits mailing list