[clang-tools-extra] [clang-tidy] Add checker alias framework and restore hicpp aliases (PR #197927)

[via cfe-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

The build failed before running any tests. Click on a failure below to see the details.

<details>
<summary>[code=4294967295] tools/clang/tools/extra/unittests/clang-tidy/ClangTidyTests.exe</summary>

```
FAILED: [code=4294967295] tools/clang/tools/extra/unittests/clang-tidy/ClangTidyTests.exe
C:\Windows\system32\cmd.exe /C "cd . && C:\BuildTools\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\cmake.exe -E vs_link_exe --msvc-ver=1944 --intdir=tools\clang\tools\extra\unittests\clang-tidy\CMakeFiles\ClangTidyTests.dir --rc="C:\Program Files (x86)\Windows Kits\10\bin\10.0.26100.0\x64\rc.exe" --mt="C:\Program Files (x86)\Windows Kits\10\bin\10.0.26100.0\x64\mt.exe" --manifests  -- C:\clang\clang-msvc\bin\lld-link.exe /nologo @CMakeFiles\ClangTidyTests.rsp  /out:tools\clang\tools\extra\unittests\clang-tidy\ClangTidyTests.exe /implib:tools\clang\tools\extra\unittests\clang-tidy\ClangTidyTests.lib /pdb:tools\clang\tools\extra\unittests\clang-tidy\ClangTidyTests.pdb /version:0.0 /MANIFEST:NO /INCREMENTAL:NO /subsystem:console  /STACK:10000000 && cd ."
LINK: command "C:\clang\clang-msvc\bin\lld-link.exe /nologo @CMakeFiles\ClangTidyTests.rsp /out:tools\clang\tools\extra\unittests\clang-tidy\ClangTidyTests.exe /implib:tools\clang\tools\extra\unittests\clang-tidy\ClangTidyTests.lib /pdb:tools\clang\tools\extra\unittests\clang-tidy\ClangTidyTests.pdb /version:0.0 /MANIFEST:NO /INCREMENTAL:NO /subsystem:console /STACK:10000000" failed (exit code 1) with the following output:
lld-link: error: undefined symbol: public: static class llvm::ArrayRef<struct std::pair<class llvm::StringRef, class llvm::StringRef>> __cdecl clang::tidy::ClangTidyAliases::getReference(void)
>>> referenced by clangTidy.lib(ClangTidyDiagnosticConsumer.cpp.obj):(public: void __cdecl clang::tidy::ClangTidyContext::setCurrentFile(class llvm::StringRef))

lld-link: error: undefined symbol: public: static class llvm::StringRef __cdecl clang::tidy::ClangTidyAliases::getAliasForCanonical(class llvm::StringRef)
>>> referenced by clangTidy.lib(ClangTidyDiagnosticConsumer.cpp.obj):(public: bool __cdecl clang::tidy::ClangTidyContext::shouldSuppressDiagnostic(enum clang::DiagnosticsEngine::Level, class clang::Diagnostic const &, class llvm::SmallVectorImpl<struct clang::tooling::Diagnostic> &, bool, bool))

lld-link: error: undefined symbol: public: static class llvm::StringRef __cdecl clang::tidy::ClangTidyAliases::getCanonicalForAlias(class llvm::StringRef)
>>> referenced by clangTidy.lib(ClangTidyModule.cpp.obj):(public: class std::vector<class std::unique_ptr<class clang::tidy::ClangTidyCheck, struct std::default_delete<class clang::tidy::ClangTidyCheck>>, class std::allocator<class std::unique_ptr<class clang::tidy::ClangTidyCheck, struct std::default_delete<class clang::tidy::ClangTidyCheck>>>> __cdecl clang::tidy::ClangTidyCheckFactories::createChecks(class clang::tidy::ClangTidyContext *) const)
>>> referenced by clangTidy.lib(ClangTidyModule.cpp.obj):(public: class std::vector<class std::unique_ptr<class clang::tidy::ClangTidyCheck, struct std::default_delete<class clang::tidy::ClangTidyCheck>>, class std::allocator<class std::unique_ptr<class clang::tidy::ClangTidyCheck, struct std::default_delete<class clang::tidy::ClangTidyCheck>>>> __cdecl clang::tidy::ClangTidyCheckFactories::createChecksForLanguage(class clang::tidy::ClangTidyContext *) const)
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/197927