[clang] clang/AMDGPU: Use all_equal instead of building a temporary set (PR #196742)

via cfe-commits cfe-commits at lists.llvm.org
Sat May 9 11:14:19 PDT 2026


llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-backend-amdgpu

Author: Matt Arsenault (arsenm)

<details>
<summary>Changes</summary>

Addresses comment on #<!-- -->196373

---
Full diff: https://github.com/llvm/llvm-project/pull/196742.diff


1 Files Affected:

- (modified) clang/lib/Driver/ToolChains/AMDGPU.cpp (+1-2) 


``````````diff
diff --git a/clang/lib/Driver/ToolChains/AMDGPU.cpp b/clang/lib/Driver/ToolChains/AMDGPU.cpp
index b457ee2cde1c3..d2d8e56eb22be 100644
--- a/clang/lib/Driver/ToolChains/AMDGPU.cpp
+++ b/clang/lib/Driver/ToolChains/AMDGPU.cpp
@@ -739,8 +739,7 @@ AMDGPUToolChain::TranslateArgs(const DerivedArgList &Args, StringRef BoundArch,
           << getArchName() << llvm::toString(GPUsOrErr.takeError()) << "-mcpu";
     } else {
       auto &GPUs = *GPUsOrErr;
-      if (llvm::SmallSet<llvm::StringRef, 1>(GPUs.begin(), GPUs.end()).size() >
-          1)
+      if (!llvm::all_equal(GPUs))
         getDriver().Diag(diag::warn_drv_multi_gpu_arch)
             << getArchName() << llvm::join(GPUs, ", ") << "-mcpu";
       DAL->AddJoinedArg(nullptr, Opts.getOption(options::OPT_mcpu_EQ),

``````````

</details>


https://github.com/llvm/llvm-project/pull/196742


More information about the cfe-commits mailing list