[clang] 6c5f5c1 - [Clang][Modules] Fix -Wunused-variable (#196577)
via cfe-commits
cfe-commits at lists.llvm.org
Fri May 8 09:53:34 PDT 2026
Author: Aiden Grossman
Date: 2026-05-08T09:53:29-07:00
New Revision: 6c5f5c1bad824b9dc736bb9c167a065ca71dad69
URL: https://github.com/llvm/llvm-project/commit/6c5f5c1bad824b9dc736bb9c167a065ca71dad69
DIFF: https://github.com/llvm/llvm-project/commit/6c5f5c1bad824b9dc736bb9c167a065ca71dad69.diff
LOG: [Clang][Modules] Fix -Wunused-variable (#196577)
Mark some variables [[maybe_unused]] and inline others that do not have
side effects to avoid -Wunused-variable in non-assert builds.
Added:
Modified:
clang/lib/Serialization/ASTReader.cpp
Removed:
################################################################################
diff --git a/clang/lib/Serialization/ASTReader.cpp b/clang/lib/Serialization/ASTReader.cpp
index 6b242f553c59d..dfd714dd53814 100644
--- a/clang/lib/Serialization/ASTReader.cpp
+++ b/clang/lib/Serialization/ASTReader.cpp
@@ -6327,7 +6327,8 @@ Module *ASTReader::getSubmodule(uint32_t GlobalID) {
assert(It != GlobalSubmoduleMap.end());
ModuleFile &F = *It->second;
unsigned Index = GlobalID - F.BaseSubmoduleID - NUM_PREDEF_SUBMODULE_IDS;
- unsigned LocalID = Index + F.LocalBaseSubmoduleID + NUM_PREDEF_SUBMODULE_IDS;
+ [[maybe_unused]] unsigned LocalID =
+ Index + F.LocalBaseSubmoduleID + NUM_PREDEF_SUBMODULE_IDS;
BitstreamCursor &Cursor = F.SubmodulesCursor;
SavedStreamPosition SavedPosition(Cursor);
@@ -6397,10 +6398,9 @@ Module *ASTReader::getSubmodule(uint32_t GlobalID) {
StringRef Name = Blob;
unsigned Idx = 0;
- unsigned ReadLocalID = Record[Idx++];
+ [[maybe_unused]] unsigned ReadLocalID = Record[Idx++];
assert(LocalID == ReadLocalID);
- SubmoduleID ReadGlobalID = getGlobalSubmoduleID(F, ReadLocalID);
- assert(GlobalID == ReadGlobalID);
+ assert(GlobalID == getGlobalSubmoduleID(F, ReadLocalID));
SubmoduleID Parent = getGlobalSubmoduleID(F, Record[Idx++]);
Module::ModuleKind Kind = (Module::ModuleKind)Record[Idx++];
SourceLocation DefinitionLoc = ReadSourceLocation(F, Record[Idx++]);
More information about the cfe-commits
mailing list