https://github.com/zwuis commented: > question for reviewers, should any of these diagnostics be an error? right now they're all warnings AFAIK clang-tidy checks always emit warnings and notes. https://github.com/llvm/llvm-project/pull/195974