[clang] [llvm] [SelectionDAG][NVPTX] support expanding target intrinsics; implement for `nvvm.{fmax/fmin}` (PR #194783)

via cfe-commits cfe-commits at lists.llvm.org
Wed May 6 14:52:52 PDT 2026


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {undef deprecator}-->


:warning: undef deprecator found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git diff -U0 --pickaxe-regex -S '([^a-zA-Z0-9#_-]undef([^a-zA-Z0-9_-]|$)|UndefValue::get)' 'HEAD~1' HEAD clang/lib/CodeGen/TargetBuiltins/NVPTX.cpp clang/test/CodeGen/builtins-nvptx-native-half-type-native.c clang/test/CodeGen/builtins-nvptx-native-half-type.c clang/test/CodeGen/builtins-nvptx.c llvm/include/llvm/CodeGen/TargetLowering.h llvm/include/llvm/IR/NVVMIntrinsicUtils.h llvm/lib/Analysis/ConstantFolding.cpp llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp llvm/lib/CodeGen/SelectionDAG/LegalizeTypes.cpp llvm/lib/CodeGen/SelectionDAG/LegalizeTypes.h llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp llvm/lib/IR/AutoUpgrade.cpp llvm/lib/Target/NVPTX/NVPTXISelLowering.cpp llvm/lib/Target/NVPTX/NVPTXTargetTransformInfo.cpp llvm/test/CodeGen/NVPTX/math-intrins-sm80-ptx70-instcombine.ll llvm/test/Transforms/InstCombine/NVPTX/nvvm-intrins.ll llvm/test/Transforms/InstSimplify/const-fold-nvvm-fmin-fmax.ll llvm/test/Transforms/InstSimplify/disable_folding.ll
``````````

</details>


The following files introduce new uses of undef:
 - llvm/test/Transforms/InstSimplify/const-fold-nvvm-fmin-fmax.ll

[Undef](https://llvm.org/docs/LangRef.html#undefined-values) is now deprecated and should only be used in the rare cases where no replacement is possible. For example, a load of uninitialized memory yields `undef`. You should use `poison` values for placeholders instead.

In tests, avoid using `undef` and having tests that trigger undefined behavior. If you need an operand with some unimportant value, you can add a new argument to the function and use that instead.

For example, this is considered a bad practice:
```llvm
define void @fn() {
  ...
  br i1 undef, ...
}
```

Please use the following instead:
```llvm
define void @fn(i1 %cond) {
  ...
  br i1 %cond, ...
}
```

Please refer to the [Undefined Behavior Manual](https://llvm.org/docs/UndefinedBehavior.html) for more information.



https://github.com/llvm/llvm-project/pull/194783


More information about the cfe-commits mailing list