[clang] [Clang] Use const reference arguments in ClangAttrEmitter. NFC. (PR #193928)

[Jay Foad via cfe-commits]

https://github.com/jayfoad updated https://github.com/llvm/llvm-project/pull/193928

>From 50478c0af0a76b27541f98867c37579ceaaa47a7 Mon Sep 17 00:00:00 2001
From: Jay Foad <jay.foad at amd.com>
Date: Fri, 24 Apr 2026 10:42:39 +0100
Subject: [PATCH 1/2] [Clang] Use const reference arguments in
 ClangAttrEmitter. NFC.

Fixes #94372
---
 clang/utils/TableGen/ClangAttrEmitter.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/clang/utils/TableGen/ClangAttrEmitter.cpp b/clang/utils/TableGen/ClangAttrEmitter.cpp
index d709445b59f2a..e6904f634f4a4 100644
--- a/clang/utils/TableGen/ClangAttrEmitter.cpp
+++ b/clang/utils/TableGen/ClangAttrEmitter.cpp
@@ -416,8 +416,8 @@ namespace {
 
   public:
     DefaultSimpleArgument(const Record &Arg, StringRef Attr,
-                          std::string T, int64_t Default)
-      : SimpleArgument(Arg, Attr, T), Default(Default) {}
+                          const std::string &T, int64_t Default)
+        : SimpleArgument(Arg, Attr, T), Default(Default) {}
 
     void writeAccessors(raw_ostream &OS) const override {
       SimpleArgument::writeAccessors(OS);
@@ -5314,7 +5314,7 @@ class SpellingList {
     return Spellings[(size_t)K];
   }
 
-  void add(const Record &Attr, FlattenedSpelling Spelling) {
+  void add(const Record &Attr, const FlattenedSpelling &Spelling) {
     SpellingKind Kind =
         StringSwitch<SpellingKind>(Spelling.variety())
             .Case("GNU", SpellingKind::GNU)

>From 74c25351705801de0d0d9f463cd58ad755016601 Mon Sep 17 00:00:00 2001
From: Jay Foad <jay.foad at amd.com>
Date: Wed, 6 May 2026 11:07:51 +0100
Subject: [PATCH 2/2] Use move semantics instead

---
 clang/utils/TableGen/ClangAttrEmitter.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/clang/utils/TableGen/ClangAttrEmitter.cpp b/clang/utils/TableGen/ClangAttrEmitter.cpp
index e6904f634f4a4..bb0e9374b19b7 100644
--- a/clang/utils/TableGen/ClangAttrEmitter.cpp
+++ b/clang/utils/TableGen/ClangAttrEmitter.cpp
@@ -416,8 +416,8 @@ namespace {
 
   public:
     DefaultSimpleArgument(const Record &Arg, StringRef Attr,
-                          const std::string &T, int64_t Default)
-        : SimpleArgument(Arg, Attr, T), Default(Default) {}
+                          std::string T, int64_t Default)
+        : SimpleArgument(Arg, Attr, std::move(T)), Default(Default) {}
 
     void writeAccessors(raw_ostream &OS) const override {
       SimpleArgument::writeAccessors(OS);