[clang] [CIR][AArch64] Upstream Neon vget_lane/vgetq_lane builtins (PR #186119)

Andrzej Warzyński via cfe-commits cfe-commits at lists.llvm.org
Wed May 6 03:07:43 PDT 2026


https://github.com/banach-space commented:

Thank you for the updates, this is really close!

I've posted some minor comments inline. I have also noticed that 52 new tests are added, but only 48 are deleted. Looks 4 more tests should be deleted?

Here's a list of the intrinsics in your group:
```bash
vdupb_lane_s8
vduph_lane_s16
vdups_lane_s32
vdupd_lane_s64
vdupb_lane_u8
vduph_lane_u16
vdups_lane_u32
vdupd_lane_u64
vdups_lane_f32
vdupd_lane_f64
vdupb_lane_p8
vduph_lane_p16
vdupb_lane_mf8
vdupb_laneq_s8
vduph_laneq_s16
vdups_laneq_s32
vdupd_laneq_s64
vdupb_laneq_u8
vduph_laneq_u16
vdups_laneq_u32
vdupd_laneq_u64
vdups_laneq_f32
vdupd_laneq_f64
vdupb_laneq_p8
vduph_laneq_p16
vdupb_laneq_mf8
vget_lane_u8
vget_lane_u16
vget_lane_u32
vget_lane_u64
vget_lane_p64
vget_lane_s8
vget_lane_s16
vget_lane_s32
vget_lane_s64
vget_lane_p8
vget_lane_p16
vget_lane_mf8
vget_lane_f16
vget_lane_f32
vget_lane_f64
vgetq_lane_u8
vgetq_lane_u16
vgetq_lane_u32
vgetq_lane_u64
vgetq_lane_p64
vgetq_lane_s8
vgetq_lane_s16
vgetq_lane_s32
vgetq_lane_s64
vgetq_lane_p8
vgetq_lane_p16
vgetq_lane_mf8
vgetq_lane_f16
vgetq_lane_f32
vgetq_lane_f64
```

Could you x-check and see what is missing from the deleted tests? Thank you 🙏🏻 

https://github.com/llvm/llvm-project/pull/186119


More information about the cfe-commits mailing list