[clang] 58f94f0 - clang: Report full triple arch string in --offload-arch diagnostic (#195849)
via cfe-commits
cfe-commits at lists.llvm.org
Tue May 5 06:31:08 PDT 2026
Author: Matt Arsenault
Date: 2026-05-05T13:31:03Z
New Revision: 58f94f0a4648a5d8d624c05a51dea8c37e5fe7bc
URL: https://github.com/llvm/llvm-project/commit/58f94f0a4648a5d8d624c05a51dea8c37e5fe7bc
DIFF: https://github.com/llvm/llvm-project/commit/58f94f0a4648a5d8d624c05a51dea8c37e5fe7bc.diff
LOG: clang: Report full triple arch string in --offload-arch diagnostic (#195849)
This was previously only printing the top level arch string. Print
the full arch + subarch from the triple.
Added:
Modified:
clang/lib/Driver/Driver.cpp
Removed:
################################################################################
diff --git a/clang/lib/Driver/Driver.cpp b/clang/lib/Driver/Driver.cpp
index a283abef09f32..b9c072a0a0edb 100644
--- a/clang/lib/Driver/Driver.cpp
+++ b/clang/lib/Driver/Driver.cpp
@@ -4879,7 +4879,7 @@ Driver::getOffloadArchs(Compilation &C, const llvm::opt::DerivedArgList &Args,
auto GPUsOrErr = TC.getSystemGPUArchs(Args);
if (!GPUsOrErr) {
TC.getDriver().Diag(diag::err_drv_undetermined_gpu_arch)
- << llvm::Triple::getArchTypeName(TC.getArch())
+ << TC.getTriple().getArchName()
<< llvm::toString(GPUsOrErr.takeError()) << "--offload-arch";
continue;
}
@@ -4940,8 +4940,8 @@ Driver::getOffloadArchs(Compilation &C, const llvm::opt::DerivedArgList &Args,
auto ArchsOrErr = TC.getSystemGPUArchs(Args);
if (!ArchsOrErr) {
TC.getDriver().Diag(diag::err_drv_undetermined_gpu_arch)
- << llvm::Triple::getArchTypeName(TC.getArch())
- << llvm::toString(ArchsOrErr.takeError()) << "--offload-arch";
+ << TC.getArchName() << llvm::toString(ArchsOrErr.takeError())
+ << "--offload-arch";
} else if (!ArchsOrErr->empty()) {
for (auto Arch : *ArchsOrErr)
Archs.insert(Args.MakeArgStringRef(Arch));
More information about the cfe-commits
mailing list