[clang] [clang][P2719] Relax requirements for matching operator new and delete (PR #195779)

via cfe-commits cfe-commits at lists.llvm.org
Tue May 5 01:32:06 PDT 2026


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- clang/lib/Sema/SemaCoroutine.cpp clang/lib/Sema/SemaDeclCXX.cpp clang/lib/Sema/SemaExprCXX.cpp clang/test/SemaCXX/type-aware-class-scoped-mismatched-constraints.cpp clang/test/SemaCXX/type-aware-coroutines.cpp clang/test/SemaCXX/type-aware-new-delete-basic-resolution.cpp clang/test/SemaCXX/type-aware-placement-operators.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/lib/Sema/SemaDeclCXX.cpp b/clang/lib/Sema/SemaDeclCXX.cpp
index 3961d29c1..be87b9ff4 100644
--- a/clang/lib/Sema/SemaDeclCXX.cpp
+++ b/clang/lib/Sema/SemaDeclCXX.cpp
@@ -7465,14 +7465,11 @@ void Sema::CheckCompletedCXXClass(Scope *S, CXXRecordDecl *Record) {
 
   auto CheckMismatchedTypeAwareAllocators =
       [&](OverloadedOperatorKind NewKind, OverloadedOperatorKind DeleteKind) {
-        bool HasTypeAwareNew =
-          TypeAwareAllocatorDeclKinds.contains(NewKind);
-        bool HasClassScopedNew =
-          AllocatorDeclsKinds.contains(NewKind);
+        bool HasTypeAwareNew = TypeAwareAllocatorDeclKinds.contains(NewKind);
+        bool HasClassScopedNew = AllocatorDeclsKinds.contains(NewKind);
         bool HasTypeAwareDelete =
-          TypeAwareAllocatorDeclKinds.contains(DeleteKind);
-        bool HasClassScopedDelete =
-          AllocatorDeclsKinds.contains(DeleteKind);
+            TypeAwareAllocatorDeclKinds.contains(DeleteKind);
+        bool HasClassScopedDelete = AllocatorDeclsKinds.contains(DeleteKind);
 
         // No type aware allocators so nothing to do.
         if (!HasTypeAwareNew && !HasTypeAwareDelete)
diff --git a/clang/lib/Sema/SemaExprCXX.cpp b/clang/lib/Sema/SemaExprCXX.cpp
index c4f4b7323..c8b7b6deb 100644
--- a/clang/lib/Sema/SemaExprCXX.cpp
+++ b/clang/lib/Sema/SemaExprCXX.cpp
@@ -3149,13 +3149,13 @@ bool Sema::FindAllocationFunctions(
             << OperatorNew->getDeclName() << Error << IsPlacementOperator
             << DeleteName;
         Diag(OperatorNew->getLocation(),
-              diag::note_type_aware_operator_declared)
+             diag::note_type_aware_operator_declared)
             << OperatorNew->getDeclName() << OperatorNewContext;
 
         if (Error == TypeAwareCleanupOperatorError::MismatchedScope) {
           DeclContext *OperatorDeleteContext = GetRedeclContext(OperatorDelete);
           Diag(OperatorDelete->getLocation(),
-                diag::note_type_aware_operator_declared)
+               diag::note_type_aware_operator_declared)
               << OperatorDelete->getDeclName() << OperatorDeleteContext;
         }
       };

``````````

</details>


https://github.com/llvm/llvm-project/pull/195779


More information about the cfe-commits mailing list