[clang] [CIR][AArch64] Upstream for vector vector shl (PR #191655)

[Andrzej Warzyński via cfe-commits]

================
@@ -849,17 +849,21 @@ static mlir::Value emitCommonNeonBuiltinExpr(
   case NEON::BI__builtin_neon_vbfdot_f32:
   case NEON::BI__builtin_neon_vbfdotq_f32:
   case NEON::BI__builtin_neon___a32_vcvt_bf16_f32:
-  default:
-    cgf.cgm.errorNYI(expr->getSourceRange(),
-                     std::string("unimplemented AArch64 builtin call: ") +
-                         ctx.BuiltinInfo.getName(builtinID));
-    return mlir::Value{};
-
     cgf.cgm.errorNYI(expr->getSourceRange(),
                      std::string("unimplemented AArch64 builtin call: ") +
                          ctx.BuiltinInfo.getName(builtinID));
     return mlir::Value{};
   }
+
----------------
banach-space wrote:

```suggestion
    // The switch stmt is intended to help catch NYI cases and will be removed
    // once the CIR implementation is complete. Avoid adding specialized
    // code in cases - that should only be required for a handful of examples.
    switch (info.BuiltinID) {
    default:
      cgf.cgm.errorNYI(expr->getSourceRange(),
                       std::string("unimplemented AArch64 builtin call: ") +
                           cgf.getContext().BuiltinInfo.getName(info.BuiltinID));
      break;
     case <builtin-from-this-pr> {
       // The implementation that you added here
        return cgf.getBuilder().createBitcast(result, resultType);
     } 
     
     // NYI
     return nullptr;
```

https://github.com/llvm/llvm-project/pull/191655