[clang] [NFC][CIR] Pass StringRef to `getIntrinsicForClangBuiltin` directly (PR #195458)
Rahul Joshi via cfe-commits
cfe-commits at lists.llvm.org
Sat May 2 08:03:06 PDT 2026
https://github.com/jurahul created https://github.com/llvm/llvm-project/pull/195458
None
>From 6794fef0054c769a7cc7153c431a6c00c9b07ad4 Mon Sep 17 00:00:00 2001
From: Rahul Joshi <rjoshi at nvidia.com>
Date: Sat, 2 May 2026 08:01:37 -0700
Subject: [PATCH] [NFC][CIR] Pass StringRef to `getIntrinsicForClangBuiltin`
directly
---
clang/lib/CIR/CodeGen/CIRGenBuiltin.cpp | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/clang/lib/CIR/CodeGen/CIRGenBuiltin.cpp b/clang/lib/CIR/CodeGen/CIRGenBuiltin.cpp
index fa0d02f9e4eef..d5bfe267255a8 100644
--- a/clang/lib/CIR/CodeGen/CIRGenBuiltin.cpp
+++ b/clang/lib/CIR/CodeGen/CIRGenBuiltin.cpp
@@ -953,8 +953,7 @@ static cir::FuncType getIntrinsicType(CIRGenFunction &cgf,
SmallVector<mlir::Type, 8> argTypes;
bool isVarArg = false;
while (!tableRef.empty()) {
- llvm::Intrinsic::IITDescriptor::IITDescriptorKind kind =
- tableRef.front().Kind;
+ IITDescriptor::IITDescriptorKind kind = tableRef.front().Kind;
if (kind == IITDescriptor::VarArg) {
isVarArg = true;
break; // VarArg is last
@@ -2427,12 +2426,12 @@ RValue CIRGenFunction::emitBuiltinExpr(const GlobalDecl &gd, unsigned builtinID,
StringRef prefix =
llvm::Triple::getArchTypePrefix(getTarget().getTriple().getArch());
if (!prefix.empty()) {
- intrinsicID = Intrinsic::getIntrinsicForClangBuiltin(prefix.data(), name);
+ intrinsicID = Intrinsic::getIntrinsicForClangBuiltin(prefix, name);
// NOTE we don't need to perform a compatibility flag check here since the
// intrinsics are declared in Builtins*.def via LANGBUILTIN which filter the
// MS builtins via ALL_MS_LANGUAGES and are filtered earlier.
if (intrinsicID == Intrinsic::not_intrinsic)
- intrinsicID = Intrinsic::getIntrinsicForMSBuiltin(prefix.data(), name);
+ intrinsicID = Intrinsic::getIntrinsicForMSBuiltin(prefix, name);
}
if (intrinsicID != Intrinsic::not_intrinsic) {
@@ -2441,7 +2440,7 @@ RValue CIRGenFunction::emitBuiltinExpr(const GlobalDecl &gd, unsigned builtinID,
getContext().GetBuiltinType(builtinID, error, &iceArguments);
assert(error == ASTContext::GE_None && "Should not codegen an error");
- llvm::StringRef name = llvm::Intrinsic::getName(intrinsicID);
+ StringRef name = Intrinsic::getName(intrinsicID);
// cir::LLVMIntrinsicCallOp expects intrinsic name to not have prefix
// "llvm." For example, `llvm.nvvm.barrier0` should be passed as
// `nvvm.barrier0`.
More information about the cfe-commits
mailing list