[clang] [HLSL] Add matrix support to atan2 (PR #194984)

Deric C. via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 30 13:53:23 PDT 2026


================
@@ -457,7 +457,7 @@ determine the correct quadrant.
 \param x The x-coordinate.
 }];
   let VaryingTypes = [HalfTy, FloatTy];
-  let VaryingMatDims = [];
+  let VaryingMatDims = AllMatDims;
----------------
Icohedron wrote:

You can simply just remove the line because `HLSLTwoArgBuiltin` defines `let VaryingMatDims = AllMatDims;`.
The previous `let VaryingMatDims = [];` was just overriding it to disallow matrix types.
```suggestion
```

https://github.com/llvm/llvm-project/pull/194984


More information about the cfe-commits mailing list