[clang] [NFC][HLSL] Remove dead branch for const return by value (PR #194983)

[via cfe-commits]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang

Author: Joshua Batista (bob80905)

<details>
<summary>Changes</summary>

Remove unreachable addConst() on the by-value return path of addHandleAccessFunction. 
No caller passes IsConstReturn=true with IsRef=false. The existing AST tests ( StructuredBuffers-AST.hlsl, ByteAddressBuffers-AST.hlsl, TypedBuffers-AST.hlsl) already assert the by-value Load return type is non-const, so behavior is verified unchanged.


Assisted by: Github Copilot
Fixes https://github.com/llvm/llvm-project/issues/194982

---
Full diff: https://github.com/llvm/llvm-project/pull/194983.diff


1 Files Affected:

- (modified) clang/lib/Sema/HLSLBuiltinTypeDeclBuilder.cpp (-2) 


``````````diff
diff --git a/clang/lib/Sema/HLSLBuiltinTypeDeclBuilder.cpp b/clang/lib/Sema/HLSLBuiltinTypeDeclBuilder.cpp
index ba8e63f01527a..1819b1749b3be 100644
--- a/clang/lib/Sema/HLSLBuiltinTypeDeclBuilder.cpp
+++ b/clang/lib/Sema/HLSLBuiltinTypeDeclBuilder.cpp
@@ -2263,8 +2263,6 @@ BuiltinTypeDeclBuilder &BuiltinTypeDeclBuilder::addHandleAccessFunction(
     ReturnTy = AST.getLValueReferenceType(ReturnTy);
   } else {
     ReturnTy = ElemTy;
-    if (IsConstReturn)
-      ReturnTy.addConst();
   }
   MMB.ReturnTy = ReturnTy;
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/194983