[clang] [NFC][HLSL] Remove dead branch for const return by value (PR #194983)

[Joshua Batista via cfe-commits]

https://github.com/bob80905 created https://github.com/llvm/llvm-project/pull/194983

Remove unreachable addConst() on the by-value return path of addHandleAccessFunction. 
No caller passes IsConstReturn=true with IsRef=false. The existing AST tests ( StructuredBuffers-AST.hlsl, ByteAddressBuffers-AST.hlsl, TypedBuffers-AST.hlsl) already assert the by-value Load return type is non-const, so behavior is verified unchanged.


Assisted by: Github Copilot
Fixes https://github.com/llvm/llvm-project/issues/194982

>From 384cdfde5941619a2fddfd058501147bb67eefdb Mon Sep 17 00:00:00 2001
From: Joshua Batista <jbatista at microsoft.com>
Date: Wed, 29 Apr 2026 16:41:12 -0700
Subject: [PATCH] first attempt

---
 clang/lib/Sema/HLSLBuiltinTypeDeclBuilder.cpp | 2 --
 1 file changed, 2 deletions(-)

diff --git a/clang/lib/Sema/HLSLBuiltinTypeDeclBuilder.cpp b/clang/lib/Sema/HLSLBuiltinTypeDeclBuilder.cpp
index ba8e63f01527a..1819b1749b3be 100644
--- a/clang/lib/Sema/HLSLBuiltinTypeDeclBuilder.cpp
+++ b/clang/lib/Sema/HLSLBuiltinTypeDeclBuilder.cpp
@@ -2263,8 +2263,6 @@ BuiltinTypeDeclBuilder &BuiltinTypeDeclBuilder::addHandleAccessFunction(
     ReturnTy = AST.getLValueReferenceType(ReturnTy);
   } else {
     ReturnTy = ElemTy;
-    if (IsConstReturn)
-      ReturnTy.addConst();
   }
   MMB.ReturnTy = ReturnTy;