[clang] [clang][bytecode] Stop relying on `CheckEvaluationResult()` (PR #186045)

[via cfe-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

* 53763 tests passed
* 1164 tests skipped
* 1 test failed

## Failed Tests
(click on a test name to see its output)

### Clang
<details>
<summary>Clang.AST/ByteCode/c.c</summary>

```
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
c:\_work\llvm-project\llvm-project\build\bin\clang.exe -cc1 -internal-isystem C:\_work\llvm-project\llvm-project\build\lib\clang\23\include -nostdsysteminc -triple x86_64-linux -verify=expected,all                   -std=c11 -Wcast-qual           C:\_work\llvm-project\llvm-project\clang\test\AST\ByteCode\c.c -fexperimental-new-constant-interpreter
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\clang.exe' -cc1 -internal-isystem 'C:\_work\llvm-project\llvm-project\build\lib\clang\23\include' -nostdsysteminc -triple x86_64-linux -verify=expected,all -std=c11 -Wcast-qual 'C:\_work\llvm-project\llvm-project\clang\test\AST\ByteCode\c.c' -fexperimental-new-constant-interpreter
# note: command had no output on stdout or stderr
# RUN: at line 2
c:\_work\llvm-project\llvm-project\build\bin\clang.exe -cc1 -internal-isystem C:\_work\llvm-project\llvm-project\build\lib\clang\23\include -nostdsysteminc -triple x86_64-linux -verify=pedantic,pedantic-expected,all -std=c11 -Wcast-qual -pedantic C:\_work\llvm-project\llvm-project\clang\test\AST\ByteCode\c.c -fexperimental-new-constant-interpreter
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\clang.exe' -cc1 -internal-isystem 'C:\_work\llvm-project\llvm-project\build\lib\clang\23\include' -nostdsysteminc -triple x86_64-linux -verify=pedantic,pedantic-expected,all -std=c11 -Wcast-qual -pedantic 'C:\_work\llvm-project\llvm-project\clang\test\AST\ByteCode\c.c' -fexperimental-new-constant-interpreter
# .---command stderr------------
# | error: diagnostics with 'note' severity expected but not seen: 
# |   File C:\_work\llvm-project\llvm-project\clang\test\AST\ByteCode\c.c Line 238 'pedantic-expected-note': this conversion is not allowed in a constant expression
# | 1 error generated.
# `-----------------------------
# error: command failed with exit status: 1

--

```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/186045