[clang-tools-extra] [clang-tidy] Migrate explicit-constructor check from google to misc and add relative aliases (PR #194796)
via cfe-commits
cfe-commits at lists.llvm.org
Wed Apr 29 00:07:07 PDT 2026
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang-tools-extra
Author: Mao Chuanjun (maochuanjun)
<details>
<summary>Changes</summary>
Fixes #<!-- -->126032
---
Patch is 22.40 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/194796.diff
16 Files Affected:
- (modified) clang-tools-extra/clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp (+3)
- (modified) clang-tools-extra/clang-tidy/google/CMakeLists.txt (-1)
- (modified) clang-tools-extra/clang-tidy/google/GoogleTidyModule.cpp (+2-2)
- (modified) clang-tools-extra/clang-tidy/hicpp/HICPPTidyModule.cpp (+2-2)
- (modified) clang-tools-extra/clang-tidy/misc/CMakeLists.txt (+1)
- (renamed) clang-tools-extra/clang-tidy/misc/ExplicitConstructorCheck.cpp (+2-2)
- (renamed) clang-tools-extra/clang-tidy/misc/ExplicitConstructorCheck.h (+6-8)
- (modified) clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp (+3)
- (modified) clang-tools-extra/docs/ReleaseNotes.rst (+15)
- (added) clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/explicit-constructor.rst (+8)
- (modified) clang-tools-extra/docs/clang-tidy/checks/google/explicit-constructor.rst (+3-51)
- (modified) clang-tools-extra/docs/clang-tidy/checks/hicpp/explicit-conversions.rst (+1-1)
- (modified) clang-tools-extra/docs/clang-tidy/checks/list.rst (+3-1)
- (added) clang-tools-extra/docs/clang-tidy/checks/misc/explicit-constructor.rst (+56)
- (renamed) clang-tools-extra/test/clang-tidy/checkers/misc/explicit-constructor-cxx20.cpp (+6-3)
- (renamed) clang-tools-extra/test/clang-tidy/checkers/misc/explicit-constructor.cpp (+9-6)
``````````diff
diff --git a/clang-tools-extra/clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp b/clang-tools-extra/clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
index fab4f92be22b6..402579adfb5d3 100644
--- a/clang-tools-extra/clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
+++ b/clang-tools-extra/clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
@@ -9,6 +9,7 @@
#include "../ClangTidy.h"
#include "../ClangTidyModule.h"
#include "../bugprone/NarrowingConversionsCheck.h"
+#include "../misc/ExplicitConstructorCheck.h"
#include "../misc/NonPrivateMemberVariablesInClassesCheck.h"
#include "../misc/UnconventionalAssignOperatorCheck.h"
#include "../modernize/AvoidCArraysCheck.h"
@@ -75,6 +76,8 @@ class CppCoreGuidelinesModule : public ClangTidyModule {
"cppcoreguidelines-avoid-non-const-global-variables");
CheckFactories.registerCheck<AvoidReferenceCoroutineParametersCheck>(
"cppcoreguidelines-avoid-reference-coroutine-parameters");
+ CheckFactories.registerCheck<misc::ExplicitConstructorCheck>(
+ "cppcoreguidelines-explicit-constructor");
CheckFactories.registerCheck<modernize::UseOverrideCheck>(
"cppcoreguidelines-explicit-virtual-functions");
CheckFactories.registerCheck<InitVariablesCheck>(
diff --git a/clang-tools-extra/clang-tidy/google/CMakeLists.txt b/clang-tools-extra/clang-tidy/google/CMakeLists.txt
index 71b555d5e538b..0ac12ababc74a 100644
--- a/clang-tools-extra/clang-tidy/google/CMakeLists.txt
+++ b/clang-tools-extra/clang-tidy/google/CMakeLists.txt
@@ -8,7 +8,6 @@ add_clang_library(clangTidyGoogleModule STATIC
AvoidThrowingObjCExceptionCheck.cpp
AvoidUnderscoreInGoogletestNameCheck.cpp
DefaultArgumentsCheck.cpp
- ExplicitConstructorCheck.cpp
ExplicitMakePairCheck.cpp
FloatTypesCheck.cpp
FunctionNamingCheck.cpp
diff --git a/clang-tools-extra/clang-tidy/google/GoogleTidyModule.cpp b/clang-tools-extra/clang-tidy/google/GoogleTidyModule.cpp
index fd015e951e837..e21b6dec8d1ab 100644
--- a/clang-tools-extra/clang-tidy/google/GoogleTidyModule.cpp
+++ b/clang-tools-extra/clang-tidy/google/GoogleTidyModule.cpp
@@ -9,6 +9,7 @@
#include "../ClangTidy.h"
#include "../ClangTidyModule.h"
#include "../misc/AnonymousNamespaceInHeaderCheck.h"
+#include "../misc/ExplicitConstructorCheck.h"
#include "../modernize/AvoidCStyleCastCheck.h"
#include "../readability/BracesAroundStatementsCheck.h"
#include "../readability/FunctionSizeCheck.h"
@@ -17,7 +18,6 @@
#include "AvoidThrowingObjCExceptionCheck.h"
#include "AvoidUnderscoreInGoogletestNameCheck.h"
#include "DefaultArgumentsCheck.h"
-#include "ExplicitConstructorCheck.h"
#include "ExplicitMakePairCheck.h"
#include "FloatTypesCheck.h"
#include "FunctionNamingCheck.h"
@@ -46,7 +46,7 @@ class GoogleModule : public ClangTidyModule {
"google-build-using-namespace");
CheckFactories.registerCheck<DefaultArgumentsCheck>(
"google-default-arguments");
- CheckFactories.registerCheck<ExplicitConstructorCheck>(
+ CheckFactories.registerCheck<misc::ExplicitConstructorCheck>(
"google-explicit-constructor");
CheckFactories.registerCheck<readability::GlobalNamesInHeadersCheck>(
"google-global-names-in-headers");
diff --git a/clang-tools-extra/clang-tidy/hicpp/HICPPTidyModule.cpp b/clang-tools-extra/clang-tidy/hicpp/HICPPTidyModule.cpp
index 501e7fc0e2d9b..c87056f9141ca 100644
--- a/clang-tools-extra/clang-tidy/hicpp/HICPPTidyModule.cpp
+++ b/clang-tools-extra/clang-tidy/hicpp/HICPPTidyModule.cpp
@@ -19,7 +19,7 @@
#include "../cppcoreguidelines/ProTypeMemberInitCheck.h"
#include "../cppcoreguidelines/ProTypeVarargCheck.h"
#include "../cppcoreguidelines/SpecialMemberFunctionsCheck.h"
-#include "../google/ExplicitConstructorCheck.h"
+#include "../misc/ExplicitConstructorCheck.h"
#include "../misc/NewDeleteOverloadsCheck.h"
#include "../misc/StaticAssertCheck.h"
#include "../modernize/AvoidCArraysCheck.h"
@@ -63,7 +63,7 @@ class HICPPModule : public ClangTidyModule {
"hicpp-multiway-paths-covered");
CheckFactories.registerCheck<bugprone::SignedBitwiseCheck>(
"hicpp-signed-bitwise");
- CheckFactories.registerCheck<google::ExplicitConstructorCheck>(
+ CheckFactories.registerCheck<misc::ExplicitConstructorCheck>(
"hicpp-explicit-conversions");
CheckFactories.registerCheck<readability::FunctionSizeCheck>(
"hicpp-function-size");
diff --git a/clang-tools-extra/clang-tidy/misc/CMakeLists.txt b/clang-tools-extra/clang-tidy/misc/CMakeLists.txt
index e34b0cf687be3..abf1a69329d5e 100644
--- a/clang-tools-extra/clang-tidy/misc/CMakeLists.txt
+++ b/clang-tools-extra/clang-tidy/misc/CMakeLists.txt
@@ -22,6 +22,7 @@ add_clang_library(clangTidyMiscModule STATIC
ConstCorrectnessCheck.cpp
CoroutineHostileRAIICheck.cpp
DefinitionsInHeadersCheck.cpp
+ ExplicitConstructorCheck.cpp
ConfusableIdentifierCheck.cpp
HeaderIncludeCycleCheck.cpp
IncludeCleanerCheck.cpp
diff --git a/clang-tools-extra/clang-tidy/google/ExplicitConstructorCheck.cpp b/clang-tools-extra/clang-tidy/misc/ExplicitConstructorCheck.cpp
similarity index 98%
rename from clang-tools-extra/clang-tidy/google/ExplicitConstructorCheck.cpp
rename to clang-tools-extra/clang-tidy/misc/ExplicitConstructorCheck.cpp
index 2c64c97a2e95d..8c6f8ef978991 100644
--- a/clang-tools-extra/clang-tidy/google/ExplicitConstructorCheck.cpp
+++ b/clang-tools-extra/clang-tidy/misc/ExplicitConstructorCheck.cpp
@@ -14,7 +14,7 @@
using namespace clang::ast_matchers;
-namespace clang::tidy::google {
+namespace clang::tidy::misc {
void ExplicitConstructorCheck::registerMatchers(MatchFinder *Finder) {
Finder->addMatcher(
@@ -136,4 +136,4 @@ void ExplicitConstructorCheck::check(const MatchFinder::MatchResult &Result) {
Diag << FixItHint::CreateInsertion(Loc, "explicit ");
}
-} // namespace clang::tidy::google
+} // namespace clang::tidy::misc
diff --git a/clang-tools-extra/clang-tidy/google/ExplicitConstructorCheck.h b/clang-tools-extra/clang-tidy/misc/ExplicitConstructorCheck.h
similarity index 68%
rename from clang-tools-extra/clang-tidy/google/ExplicitConstructorCheck.h
rename to clang-tools-extra/clang-tidy/misc/ExplicitConstructorCheck.h
index 0954a83223b7c..44e37bdb08ca8 100644
--- a/clang-tools-extra/clang-tidy/google/ExplicitConstructorCheck.h
+++ b/clang-tools-extra/clang-tidy/misc/ExplicitConstructorCheck.h
@@ -6,19 +6,17 @@
//
//===----------------------------------------------------------------------===//
-#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_GOOGLE_EXPLICITCONSTRUCTORCHECK_H
-#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_GOOGLE_EXPLICITCONSTRUCTORCHECK_H
+#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_EXPLICITCONSTRUCTORCHECK_H
+#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_EXPLICITCONSTRUCTORCHECK_H
#include "../ClangTidyCheck.h"
-namespace clang::tidy::google {
+namespace clang::tidy::misc {
/// Checks that all single-argument constructors are explicit.
///
-/// See https://google.github.io/styleguide/cppguide.html#Explicit_Constructors
-///
/// For the user-facing documentation see:
-/// https://clang.llvm.org/extra/clang-tidy/checks/google/explicit-constructor.html
+/// https://clang.llvm.org/extra/clang-tidy/checks/misc/explicit-constructor.html
class ExplicitConstructorCheck : public ClangTidyCheck {
public:
ExplicitConstructorCheck(StringRef Name, ClangTidyContext *Context)
@@ -30,6 +28,6 @@ class ExplicitConstructorCheck : public ClangTidyCheck {
void check(const ast_matchers::MatchFinder::MatchResult &Result) override;
};
-} // namespace clang::tidy::google
+} // namespace clang::tidy::misc
-#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_GOOGLE_EXPLICITCONSTRUCTORCHECK_H
+#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_EXPLICITCONSTRUCTORCHECK_H
diff --git a/clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp b/clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp
index f8550b30b9789..5a716606495db 100644
--- a/clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp
+++ b/clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp
@@ -13,6 +13,7 @@
#include "ConstCorrectnessCheck.h"
#include "CoroutineHostileRAIICheck.h"
#include "DefinitionsInHeadersCheck.h"
+#include "ExplicitConstructorCheck.h"
#include "HeaderIncludeCycleCheck.h"
#include "IncludeCleanerCheck.h"
#include "MisleadingBidirectionalCheck.h"
@@ -53,6 +54,8 @@ class MiscModule : public ClangTidyModule {
"misc-coroutine-hostile-raii");
CheckFactories.registerCheck<DefinitionsInHeadersCheck>(
"misc-definitions-in-headers");
+ CheckFactories.registerCheck<ExplicitConstructorCheck>(
+ "misc-explicit-constructor");
CheckFactories.registerCheck<HeaderIncludeCycleCheck>(
"misc-header-include-cycle");
CheckFactories.registerCheck<IncludeCleanerCheck>("misc-include-cleaner");
diff --git a/clang-tools-extra/docs/ReleaseNotes.rst b/clang-tools-extra/docs/ReleaseNotes.rst
index 52aaa2d0df552..c8206a50dccb8 100644
--- a/clang-tools-extra/docs/ReleaseNotes.rst
+++ b/clang-tools-extra/docs/ReleaseNotes.rst
@@ -199,12 +199,27 @@ New check aliases
to :doc:`bugprone-assignment-in-selection-statement
<clang-tidy/checks/bugprone/assignment-in-selection-statement>`.
+- Renamed :doc:`cppcoreguidelines-explicit-constructor <clang-tidy/checks/cppcoreguidelines/explicit-constructor>`
+ to :doc:`misc-explicit-constructor
+ <clang-tidy/checks/misc/explicit-constructor>`. The `cppcoreguidelines-explicit-constructor`
+ name is kept as an alias.
+
+- Renamed :doc:`google-explicit-constructor <clang-tidy/checks/google/explicit-constructor>`
+ to :doc:`misc-explicit-constructor
+ <clang-tidy/checks/misc/explicit-constructor>`. The `google-explicit-constructor`
+ name is kept as an alias.
+
- Renamed :doc:`hicpp-exception-baseclass
<clang-tidy/checks/hicpp/exception-baseclass>`
to :doc:`bugprone-std-exception-baseclass
<clang-tidy/checks/bugprone/std-exception-baseclass>`.
The `hicpp-exception-baseclass` name is kept as an alias.
+- Renamed :doc:`hicpp-explicit-conversions <clang-tidy/checks/hicpp/explicit-conversions>`
+ to :doc:`misc-explicit-constructor
+ <clang-tidy/checks/misc/explicit-constructor>`. The `hicpp-explicit-conversions`
+ name is kept as an alias.
+
- Renamed :doc:`hicpp-ignored-remove-result
<clang-tidy/checks/hicpp/ignored-remove-result>`
to :doc:`bugprone-unused-return-value
diff --git a/clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/explicit-constructor.rst b/clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/explicit-constructor.rst
new file mode 100644
index 0000000000000..3cc6820d7f006
--- /dev/null
+++ b/clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/explicit-constructor.rst
@@ -0,0 +1,8 @@
+.. title:: clang-tidy - cppcoreguidelines-explicit-constructor
+
+cppcoreguidelines-explicit-constructor
+======================================
+
+This check is an alias, please see
+`misc-explicit-constructor <../misc/explicit-constructor.html>`_
+for more information.
diff --git a/clang-tools-extra/docs/clang-tidy/checks/google/explicit-constructor.rst b/clang-tools-extra/docs/clang-tidy/checks/google/explicit-constructor.rst
index 1bef2686139b3..4589ae4e433f0 100644
--- a/clang-tools-extra/docs/clang-tidy/checks/google/explicit-constructor.rst
+++ b/clang-tools-extra/docs/clang-tidy/checks/google/explicit-constructor.rst
@@ -3,54 +3,6 @@
google-explicit-constructor
===========================
-
-Checks that constructors callable with a single argument and conversion
-operators are marked explicit to avoid the risk of unintentional implicit
-conversions.
-
-Consider this example:
-
-.. code-block:: c++
-
- struct S {
- int x;
- operator bool() const { return true; }
- };
-
- bool f() {
- S a{1};
- S b{2};
- return a == b;
- }
-
-The function will return ``true``, since the objects are implicitly converted
-to ``bool`` before comparison, which is unlikely to be the intent.
-
-The check will suggest inserting ``explicit`` before the constructor or
-conversion operator declaration. However, copy and move constructors should not
-be explicit, as well as constructors taking a single ``initializer_list``
-argument.
-
-This code:
-
-.. code-block:: c++
-
- struct S {
- S(int a);
- explicit S(const S&);
- operator bool() const;
- ...
-
-will become
-
-.. code-block:: c++
-
- struct S {
- explicit S(int a);
- S(const S&);
- explicit operator bool() const;
- ...
-
-
-
-See https://google.github.io/styleguide/cppguide.html#Explicit_Constructors
+This check is an alias, please see
+`misc-explicit-constructor <../misc/explicit-constructor.html>`_
+for more information.
diff --git a/clang-tools-extra/docs/clang-tidy/checks/hicpp/explicit-conversions.rst b/clang-tools-extra/docs/clang-tidy/checks/hicpp/explicit-conversions.rst
index 927f7aaf015ff..5267b0c6b12e3 100644
--- a/clang-tools-extra/docs/clang-tidy/checks/hicpp/explicit-conversions.rst
+++ b/clang-tools-extra/docs/clang-tidy/checks/hicpp/explicit-conversions.rst
@@ -4,7 +4,7 @@ hicpp-explicit-conversions
==========================
This check is an alias for
-:doc:`google-explicit-constructor <../google/explicit-constructor>`.
+:doc:`misc-explicit-constructor <../misc/explicit-constructor>`.
Used to enforce parts of `rule 5.4.1
<https://www.perforce.com/resources/qac/high-integrity-cpp-coding-rules>`_.
diff --git a/clang-tools-extra/docs/clang-tidy/checks/list.rst b/clang-tools-extra/docs/clang-tidy/checks/list.rst
index 053ce6f0779d9..f2076f8f125be 100644
--- a/clang-tools-extra/docs/clang-tidy/checks/list.rst
+++ b/clang-tools-extra/docs/clang-tidy/checks/list.rst
@@ -193,6 +193,7 @@ Clang-Tidy Checks
:doc:`cppcoreguidelines-avoid-goto <cppcoreguidelines/avoid-goto>`,
:doc:`cppcoreguidelines-avoid-non-const-global-variables <cppcoreguidelines/avoid-non-const-global-variables>`,
:doc:`cppcoreguidelines-avoid-reference-coroutine-parameters <cppcoreguidelines/avoid-reference-coroutine-parameters>`,
+ :doc:`cppcoreguidelines-explicit-constructor <cppcoreguidelines/explicit-constructor>`,
:doc:`cppcoreguidelines-init-variables <cppcoreguidelines/init-variables>`, "Yes"
:doc:`cppcoreguidelines-interfaces-global-init <cppcoreguidelines/interfaces-global-init>`,
:doc:`cppcoreguidelines-macro-usage <cppcoreguidelines/macro-usage>`,
@@ -265,6 +266,7 @@ Clang-Tidy Checks
:doc:`misc-const-correctness <misc/const-correctness>`, "Yes"
:doc:`misc-coroutine-hostile-raii <misc/coroutine-hostile-raii>`,
:doc:`misc-definitions-in-headers <misc/definitions-in-headers>`, "Yes"
+ :doc:`misc-explicit-constructor <misc/explicit-constructor>`, "Yes"
:doc:`misc-header-include-cycle <misc/header-include-cycle>`,
:doc:`misc-include-cleaner <misc/include-cleaner>`, "Yes"
:doc:`misc-misleading-bidirectional <misc/misleading-bidirectional>`,
@@ -606,7 +608,7 @@ Check aliases
:doc:`hicpp-braces-around-statements <hicpp/braces-around-statements>`, :doc:`readability-braces-around-statements <readability/braces-around-statements>`, "Yes"
:doc:`hicpp-deprecated-headers <hicpp/deprecated-headers>`, :doc:`modernize-deprecated-headers <modernize/deprecated-headers>`, "Yes"
:doc:`hicpp-exception-baseclass <hicpp/exception-baseclass>`, :doc:`bugprone-std-exception-baseclass <bugprone/std-exception-baseclass>`,
- :doc:`hicpp-explicit-conversions <hicpp/explicit-conversions>`, :doc:`google-explicit-constructor <google/explicit-constructor>`, "Yes"
+ :doc:`hicpp-explicit-conversions <hicpp/explicit-conversions>`, :doc:`misc-explicit-constructor <misc/explicit-constructor>`, "Yes"
:doc:`hicpp-function-size <hicpp/function-size>`, :doc:`readability-function-size <readability/function-size>`,
:doc:`hicpp-ignored-remove-result <hicpp/ignored-remove-result>`, :doc:`bugprone-unused-return-value <bugprone/unused-return-value>`,
:doc:`hicpp-invalid-access-moved <hicpp/invalid-access-moved>`, :doc:`bugprone-use-after-move <bugprone/use-after-move>`,
diff --git a/clang-tools-extra/docs/clang-tidy/checks/misc/explicit-constructor.rst b/clang-tools-extra/docs/clang-tidy/checks/misc/explicit-constructor.rst
new file mode 100644
index 0000000000000..3542b7713c1b2
--- /dev/null
+++ b/clang-tools-extra/docs/clang-tidy/checks/misc/explicit-constructor.rst
@@ -0,0 +1,56 @@
+.. title:: clang-tidy - misc-explicit-constructor
+
+misc-explicit-constructor
+===========================
+
+
+Checks that constructors callable with a single argument and conversion
+operators are marked explicit to avoid the risk of unintentional implicit
+conversions.
+
+Consider this example:
+
+.. code-block:: c++
+
+ struct S {
+ int x;
+ operator bool() const { return true; }
+ };
+
+ bool f() {
+ S a{1};
+ S b{2};
+ return a == b;
+ }
+
+The function will return ``true``, since the objects are implicitly converted
+to ``bool`` before comparison, which is unlikely to be the intent.
+
+The check will suggest inserting ``explicit`` before the constructor or
+conversion operator declaration. However, copy and move constructors should not
+be explicit, as well as constructors taking a single ``initializer_list``
+argument.
+
+This code:
+
+.. code-block:: c++
+
+ struct S {
+ S(int a);
+ explicit S(const S&);
+ operator bool() const;
+ ...
+
+will become
+
+.. code-block:: c++
+
+ struct S {
+ explicit S(int a);
+ S(const S&);
+ explicit operator bool() const;
+ ...
+
+
+
+See https://google.github.io/styleguide/cppguide.html#Explicit_Constructors
diff --git a/clang-tools-extra/test/clang-tidy/checkers/google/explicit-constructor-cxx20.cpp b/clang-tools-extra/test/clang-tidy/checkers/misc/explicit-constructor-cxx20.cpp
similarity index 69%
rename from clang-tools-extra/test/clang-tidy/checkers/google/explicit-constructor-cxx20.cpp
rename to clang-tools-extra/test/clang-tidy/checkers/misc/explicit-constructor-cxx20.cpp
index 95206f1ef420c..62dc908513fae 100644
--- a/clang-tools-extra/test/clang-tidy/checkers/google/explicit-constructor-cxx20.cpp
+++ b/clang-tools-extra/test/clang-tidy/checkers/misc/explicit-constructor-cxx20.cpp
@@ -1,4 +1,7 @@
-// RUN: %check_clang_tidy %s google-explicit-constructor %t -std=c++20-or-later
+// RUN: %check_clang_tidy %s misc-explicit-constructor %t -std=c++20-or-latermisc
+// RUN: %check_clang_tidy %s google-explicit-constructor %t -std=c++20-or-latermisc
+// RUN: %check_clang_tidy %s cppcoreguidelines-explicit-constructor %t -std=c++20-or-latermisc
+// RUN: %check_clang_tidy %s hicpp-explicit-conversions %t -std=c++20-or-latermisc
namespace issue_81121
{
@@ -20,7 +23,7 @@ struct C {
struct D {
explicit(ConstFalse) D(int);
- // CHECK-MESSAGES: :[[@LINE-1]]:24: warning: single-argument constructors explicit expression evaluates to 'false' [google-explicit-constructor]
+ // CHECK-MESSAGES: :[[@LINE-1]]:24: warning: single-argument constructors explicit expression evaluates to 'false' [{{.*}}]
};
template <typename>
@@ -41,7 +44,7 @@ struct G {
template <typename>
struct H {
explicit(ConstFalse) H(int);
- // CHECK-MESSAGES: :[[@LINE-1]]:24: warning: single-argument constructors explicit expression evaluates to 'false' [google-explicit-constructor]
+ // CHECK-MESSAGES: :[[@LINE-1]]:24: warning: single-argument constructors explicit expression evaluates to 'false' [{{.*}}]
};
template <int Val>
diff --git a/clang-tools-extra/test/clang-tidy/checkers/google/explicit-constructor.cpp b/clang-tools-extra/test/clang-tidy/checkers/misc/explicit-constructor.cpp
similarity index 93%
rename from clang-tools-extra/test/clang-tidy/checkers/google/explicit-constructor.cpp
rename to clang-tools-extra/test/clang-tidy/checkers/misc/explicit-constructor.cpp
index e8174b1aebb20..d88ffa5b51209 100644
--- a/clang-tools-extra/test/clang-tidy/checkers/google/explicit-constructor.cpp
+++ b/clang-tools-extra/test/clang-tidy/checkers/misc/explicit-constructor.cpp
@@ -1,4 +1,7 @@
+// RUN: %check_clang_tidy %s misc-explicit-constructor %t
// RUN: %check_clang_tidy %s google-explicit-constructor %t
+// RUN: %check_clang_tidy %s cppcoreguidelines-explicit-constructor %t
+// RUN: %check_clang_tidy %s hicpp-explicit-conversions %t
namespace std {
typedef decltype(sizeof(int)) size_t;
@@ -43,15 +46,15 @@ struct A {
operator double() const = delete;
explicit A(const A& a) {}
- // CHECK-MESSAGES: :[[...
[truncated]
``````````
</details>
https://github.com/llvm/llvm-project/pull/194796
More information about the cfe-commits
mailing list