[clang] 1c00d16 - [clang][SSAF][NFC] Remove redundant overrides from analysis templates (#193086)

[via cfe-commits]

Author: Aviral Goel
Date: 2026-04-28T14:06:57-07:00
New Revision: 1c00d1635c765044e229c91b3a88fd04c8d9d646

URL: https://github.com/llvm/llvm-project/commit/1c00d1635c765044e229c91b3a88fd04c8d9d646
DIFF: https://github.com/llvm/llvm-project/commit/1c00d1635c765044e229c91b3a88fd04c8d9d646.diff

LOG: [clang][SSAF][NFC] Remove redundant overrides from analysis templates (#193086)

This PR removes redundant:
- `initialize()` and `finalize()` overrides from `SummaryAnalysis` already provided by `SummaryAnalysisBase`.
- `step()` and `finalize()` overrides from `DerivedAnalysis<>` already provided by `DerivedAnalysisBase`.

Added: 
    

Modified: 
    clang/include/clang/ScalableStaticAnalysisFramework/Core/WholeProgramAnalysis/DerivedAnalysis.h
    clang/include/clang/ScalableStaticAnalysisFramework/Core/WholeProgramAnalysis/SummaryAnalysis.h

Removed: 
    


################################################################################
diff  --git a/clang/include/clang/ScalableStaticAnalysisFramework/Core/WholeProgramAnalysis/DerivedAnalysis.h b/clang/include/clang/ScalableStaticAnalysisFramework/Core/WholeProgramAnalysis/DerivedAnalysis.h
index 1b216ff85b947..ff9470e0a2284 100644
--- a/clang/include/clang/ScalableStaticAnalysisFramework/Core/WholeProgramAnalysis/DerivedAnalysis.h
+++ b/clang/include/clang/ScalableStaticAnalysisFramework/Core/WholeProgramAnalysis/DerivedAnalysis.h
@@ -97,13 +97,6 @@ class DerivedAnalysis : public DerivedAnalysisBase {
   /// Called once with the fixed dependency results before the step() loop.
   virtual llvm::Error initialize(const DepResultTs &...) = 0;
 
-  /// Performs one step. Returns true if another step is needed; false when
-  /// converged. Single-step analyses always return false.
-  virtual llvm::Expected<bool> step() override = 0;
-
-  /// Called after the step() loop converges. Override for post-processing.
-  virtual llvm::Error finalize() override { return llvm::Error::success(); }
-
 protected:
   /// Read-only access to the result being built.
   const ResultT &getResult() const & { return *Result; }

diff  --git a/clang/include/clang/ScalableStaticAnalysisFramework/Core/WholeProgramAnalysis/SummaryAnalysis.h b/clang/include/clang/ScalableStaticAnalysisFramework/Core/WholeProgramAnalysis/SummaryAnalysis.h
index bac7166c79177..5b7c2c9b6b8c2 100644
--- a/clang/include/clang/ScalableStaticAnalysisFramework/Core/WholeProgramAnalysis/SummaryAnalysis.h
+++ b/clang/include/clang/ScalableStaticAnalysisFramework/Core/WholeProgramAnalysis/SummaryAnalysis.h
@@ -93,16 +93,9 @@ class SummaryAnalysis : public SummaryAnalysisBase {
     return Empty;
   }
 
-  /// Called once before the first add() call. Override for initialization.
-  virtual llvm::Error initialize() override { return llvm::Error::success(); }
-
   /// Called once per matching entity. Implement to accumulate data.
   virtual llvm::Error add(EntityId Id, const EntitySummaryT &Summary) = 0;
 
-  /// Called after all entities have been processed.
-  /// Override for post-processing.
-  virtual llvm::Error finalize() override { return llvm::Error::success(); }
-
 protected:
   /// Read-only access to the result being built.
   const ResultT &getResult() const & { return *Result; }