[clang-tools-extra] [clang-tidy][readability-identifier-length] refactoring and cleanup (PR #194610)

[via cfe-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions h,cpp -- clang-tools-extra/clang-tidy/readability/IdentifierLengthCheck.cpp clang-tools-extra/clang-tidy/readability/IdentifierLengthCheck.h --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang-tools-extra/clang-tidy/readability/IdentifierLengthCheck.cpp b/clang-tools-extra/clang-tidy/readability/IdentifierLengthCheck.cpp
index 8031cbeb0..833f40eba 100644
--- a/clang-tools-extra/clang-tidy/readability/IdentifierLengthCheck.cpp
+++ b/clang-tools-extra/clang-tidy/readability/IdentifierLengthCheck.cpp
@@ -139,7 +139,7 @@ static bool isShortLived(const ValueDecl *Var, const SourceManager *SrcMgr,
 
 void IdentifierLengthCheck::check(const MatchFinder::MatchResult &Result) {
   auto ShouldWarn = [&](const ValueDecl *Var, unsigned MinNameLength,
-                        llvm::Regex const &IgnoredNames) -> bool {
+                        const llvm::Regex &IgnoredNames) -> bool {
     if (!Var->getIdentifier())
       return false;
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/194610