[clang] [C++20] [Modules] Don't profiling the callee of CXXFoldExpr (PR #190732)
Chuanqi Xu via cfe-commits
cfe-commits at lists.llvm.org
Fri Apr 24 06:15:01 PDT 2026
ChuanqiXu9 wrote:
> > > @ChuanqiXu9 The comments you added are not grammatically correct and do not correctly describe the change you made. Can you address that? thanks
> >
> >
> > yeah, I'd like to make it in a following NFC patch
>
> That's reasonable at this point but when a PR has comments from a reviewer, you should wait for the reviewer to sign-off before landing to avoid this kind of issue.
That was an accident. I pushed auto-merge and corentin comment and removed that label but the auto-merge label didn't get cancelled and it merged ... this is why I said feel free to revert.
I know it is pretty common to revert so I won't feel unhappy.
https://github.com/llvm/llvm-project/pull/190732
More information about the cfe-commits
mailing list