[clang] [CIR] Allow multi-block ctor regions on GlobalOp (PR #193596)

Erich Keane via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 23 13:03:40 PDT 2026


================
@@ -289,8 +289,8 @@ struct LoweringPreparePass
       // Emit the initializer and add a global destructor if appropriate.
       auto &ctorRegion = globalOp.getCtorRegion();
       assert(!ctorRegion.empty() && "This should never be empty here.");
-      if (!ctorRegion.hasOneBlock())
-        llvm_unreachable("Multiple blocks NYI");
+      assert(ctorRegion.hasOneBlock() &&
----------------
erichkeane wrote:

Instead of an assert, this should have been an NYI.  I'll fix it in my other patch I guess.

https://github.com/llvm/llvm-project/pull/193596


More information about the cfe-commits mailing list