[clang-tools-extra] [clangd][test] Fix test failures when LLVM_WINDOWS_PREFER_FORWARD_SLA… (PR #193160)

[Hans Wennborg via cfe-commits]

================
@@ -597,30 +597,35 @@ class TestScheme : public URIScheme {
     Body = Body.ltrim('/');
     llvm::SmallString<16> Path(Body);
     path::native(Path);
-    path::make_absolute(TestScheme::TestDir, Path);
+    path::make_absolute(getTestDir(), Path);
     return std::string(Path);
   }
 
   llvm::Expected<URI>
   uriFromAbsolutePath(llvm::StringRef AbsolutePath) const override {
     llvm::StringRef Body = AbsolutePath;
-    if (!Body.consume_front(TestScheme::TestDir))
+    if (!Body.consume_front(getTestDir()))
       return error("Path {0} doesn't start with root {1}", AbsolutePath,
-                   TestDir);
+                   getTestDir());
 
     return URI("test", /*Authority=*/"",
                llvm::sys::path::convert_to_slash(Body));
   }
 
 private:
-  const static char TestDir[];
-};
-
+  static llvm::StringRef getTestDir() {
----------------
zmodem wrote:

(nit: Maybe drop the `get` and go for just `testDir()`?)

https://github.com/llvm/llvm-project/pull/193160