[clang-tools-extra] [clang-tidy][NFC] Add a unittest for checking list.rst (PR #193134)

[via cfe-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

* 3134 tests passed
* 30 tests skipped
* 2 tests failed

## Failed Tests
(click on a test name to see its output)

### Clang Tools
<details>
<summary>Clang Tools.clang-tidy/infrastructure/alphabetical-order.test</summary>

```
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
C:/Python312/python.exe C:\_work\llvm-project\llvm-project\clang-tools-extra\test\clang-tidy\infrastructure/../../../clang-tidy/tool/check_alphabetical_order.py -o C:\_work\llvm-project\llvm-project\build\tools\clang\tools\extra\test\clang-tidy\infrastructure\Output\alphabetical-order.test.tmp.clang-tidy-checks-list.rst
# executed command: C:/Python312/python.exe 'C:\_work\llvm-project\llvm-project\clang-tools-extra\test\clang-tidy\infrastructure/../../../clang-tidy/tool/check_alphabetical_order.py' -o 'C:\_work\llvm-project\llvm-project\build\tools\clang\tools\extra\test\clang-tidy\infrastructure\Output\alphabetical-order.test.tmp.clang-tidy-checks-list.rst'
# .---command stderr------------
# | 
# | Checks in 'clang-tools-extra/docs/clang-tidy/checks/list.rst' csv-table are not alphabetically sorted.
# | Fix the ordering by applying diff printed below.
# | 
# `-----------------------------
# RUN: at line 2
diff --strip-trailing-cr C:\_work\llvm-project\llvm-project\clang-tools-extra\test\clang-tidy\infrastructure/../../../docs/clang-tidy/checks/list.rst C:\_work\llvm-project\llvm-project\build\tools\clang\tools\extra\test\clang-tidy\infrastructure\Output\alphabetical-order.test.tmp.clang-tidy-checks-list.rst
# executed command: diff --strip-trailing-cr 'C:\_work\llvm-project\llvm-project\clang-tools-extra\test\clang-tidy\infrastructure/../../../docs/clang-tidy/checks/list.rst' 'C:\_work\llvm-project\llvm-project\build\tools\clang\tools\extra\test\clang-tidy\infrastructure\Output\alphabetical-order.test.tmp.clang-tidy-checks-list.rst'
# .---command stdout------------
# | *** C:\_work\llvm-project\llvm-project\clang-tools-extra\test\clang-tidy\infrastructure/../../../docs/clang-tidy/checks/list.rst
# | --- C:\_work\llvm-project\llvm-project\build\tools\clang\tools\extra\test\clang-tidy\infrastructure\Output\alphabetical-order.test.tmp.clang-tidy-checks-list.rst
# | ***************
# | *** 76,96 ****
# |      :doc:`android-cloexec-pipe2 <android/cloexec-pipe2>`, "Yes"
# |      :doc:`android-cloexec-socket <android/cloexec-socket>`, "Yes"
# |      :doc:`android-comparison-in-temp-failure-retry <android/comparison-in-temp-failure-retry>`,
# |      :doc:`bugprone-argument-comment <bugprone/argument-comment>`, "Yes"
# | !    :doc:`boost-use-ranges <boost/use-ranges>`, "Yes"
# |      :doc:`bugprone-assignment-in-if-condition <bugprone/assignment-in-if-condition>`,
# | -    :doc:`boost-use-to-string <boost/use-to-string>`, "Yes"
# | -    :doc:`bugprone-assert-side-effect <bugprone/assert-side-effect>`,
# |      :doc:`bugprone-assignment-in-selection-statement <bugprone/assignment-in-selection-statement>`,
# |      :doc:`bugprone-bitwise-pointer-cast <bugprone/bitwise-pointer-cast>`,
# |      :doc:`bugprone-bool-pointer-implicit-conversion <bugprone/bool-pointer-implicit-conversion>`, "Yes"
# |      :doc:`bugprone-branch-clone <bugprone/branch-clone>`,
# | -    :doc:`bugprone-bad-signal-to-kill-thread <bugprone/bad-signal-to-kill-thread>`,
# |      :doc:`bugprone-capturing-this-in-member-variable <bugprone/capturing-this-in-member-variable>`,
# |      :doc:`bugprone-chained-comparison <bugprone/chained-comparison>`,
# | !    :doc:`bugprone-casting-through-void <bugprone/casting-through-void>`,
# |      :doc:`bugprone-compare-pointer-to-member-virtual-function <bugprone/compare-pointer-to-member-virtual-function>`,
# | -    :doc:`bugprone-command-processor <bugprone/command-processor>`,
# |      :doc:`bugprone-copy-constructor-init <bugprone/copy-constructor-init>`, "Yes"
# |      :doc:`bugprone-copy-constructor-mutates-argument <bugprone/copy-constructor-mutates-argument>`,
# |      :doc:`bugprone-crtp-constructor-accessibility <bugprone/crtp-constructor-accessibility>`, "Yes"
# | --- 76,96 ----
# |      :doc:`android-cloexec-pipe2 <android/cloexec-pipe2>`, "Yes"
# |      :doc:`android-cloexec-socket <android/cloexec-socket>`, "Yes"
# |      :doc:`android-comparison-in-temp-failure-retry <android/comparison-in-temp-failure-retry>`,
# | +    :doc:`boost-use-ranges <boost/use-ranges>`, "Yes"
# | +    :doc:`boost-use-to-string <boost/use-to-string>`, "Yes"
# |      :doc:`bugprone-argument-comment <bugprone/argument-comment>`, "Yes"
# | !    :doc:`bugprone-assert-side-effect <bugprone/assert-side-effect>`,
# |      :doc:`bugprone-assignment-in-if-condition <bugprone/assignment-in-if-condition>`,
# |      :doc:`bugprone-assignment-in-selection-statement <bugprone/assignment-in-selection-statement>`,
# | +    :doc:`bugprone-bad-signal-to-kill-thread <bugprone/bad-signal-to-kill-thread>`,
# |      :doc:`bugprone-bitwise-pointer-cast <bugprone/bitwise-pointer-cast>`,
# |      :doc:`bugprone-bool-pointer-implicit-conversion <bugprone/bool-pointer-implicit-conversion>`, "Yes"
# |      :doc:`bugprone-branch-clone <bugprone/branch-clone>`,
# |      :doc:`bugprone-capturing-this-in-member-variable <bugprone/capturing-this-in-member-variable>`,
# | +    :doc:`bugprone-casting-through-void <bugprone/casting-through-void>`,
# |      :doc:`bugprone-chained-comparison <bugprone/chained-comparison>`,
# | !    :doc:`bugprone-command-processor <bugprone/command-processor>`,
# |      :doc:`bugprone-compare-pointer-to-member-virtual-function <bugprone/compare-pointer-to-member-virtual-function>`,
# |      :doc:`bugprone-copy-constructor-init <bugprone/copy-constructor-init>`, "Yes"
# |      :doc:`bugprone-copy-constructor-mutates-argument <bugprone/copy-constructor-mutates-argument>`,
# |      :doc:`bugprone-crtp-constructor-accessibility <bugprone/crtp-constructor-accessibility>`, "Yes"
# | ***************
# | *** 99,108 ****
# |      :doc:`bugprone-derived-method-shadowing-base-method <bugprone/derived-method-shadowing-base-method>`,
# |      :doc:`bugprone-dynamic-static-initializers <bugprone/dynamic-static-initializers>`,
# |      :doc:`bugprone-easily-swappable-parameters <bugprone/easily-swappable-parameters>`,
# |      :doc:`bugprone-exception-copy-constructor-throws <bugprone/exception-copy-constructor-throws>`,
# |      :doc:`bugprone-exception-escape <bugprone/exception-escape>`,
# |      :doc:`bugprone-float-loop-counter <bugprone/float-loop-counter>`,
# | -    :doc:`bugprone-empty-catch <bugprone/empty-catch>`,
# |      :doc:`bugprone-fold-init-type <bugprone/fold-init-type>`,
# |      :doc:`bugprone-forward-declaration-namespace <bugprone/forward-declaration-namespace>`,
# |      :doc:`bugprone-forwarding-reference-overload <bugprone/forwarding-reference-overload>`,
# | --- 99,108 ----
# |      :doc:`bugprone-derived-method-shadowing-base-method <bugprone/derived-method-shadowing-base-method>`,
# |      :doc:`bugprone-dynamic-static-initializers <bugprone/dynamic-static-initializers>`,
# |      :doc:`bugprone-easily-swappable-parameters <bugprone/easily-swappable-parameters>`,
# | +    :doc:`bugprone-empty-catch <bugprone/empty-catch>`,
# |      :doc:`bugprone-exception-copy-constructor-throws <bugprone/exception-copy-constructor-throws>`,
# |      :doc:`bugprone-exception-escape <bugprone/exception-escape>`,
# |      :doc:`bugprone-float-loop-counter <bugprone/float-loop-counter>`,
# |      :doc:`bugprone-fold-init-type <bugprone/fold-init-type>`,
# |      :doc:`bugprone-forward-declaration-namespace <bugprone/forward-declaration-namespace>`,
# |      :doc:`bugprone-forwarding-reference-overload <bugprone/forwarding-reference-overload>`,
# `-----------------------------
# error: command failed with exit status: 1

--

```
</details>
<details>
<summary>Clang Tools.clang-tidy/infrastructure/update-checks-list.test</summary>

```
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
C:/Python312/python.exe C:\_work\llvm-project\llvm-project\clang-tools-extra\test\clang-tidy\infrastructure/../../../clang-tidy/tool/check_update_docs.py -o C:\_work\llvm-project\llvm-project\build\tools\clang\tools\extra\test\clang-tidy\infrastructure\Output\update-checks-list.test.tmp.clang-tidy-checks-list.rst
# executed command: C:/Python312/python.exe 'C:\_work\llvm-project\llvm-project\clang-tools-extra\test\clang-tidy\infrastructure/../../../clang-tidy/tool/check_update_docs.py' -o 'C:\_work\llvm-project\llvm-project\build\tools\clang\tools\extra\test\clang-tidy\infrastructure\Output\update-checks-list.test.tmp.clang-tidy-checks-list.rst'
# .---command stderr------------
# | 
# | 'clang-tools-extra/docs/clang-tidy/checks/list.rst' is out of date.
# | Fix it by running 'clang-tools-extra/clang-tidy/add_new_check.py --update-docs'.
# | 
# `-----------------------------
# RUN: at line 2
diff --strip-trailing-cr C:\_work\llvm-project\llvm-project\clang-tools-extra\test\clang-tidy\infrastructure/../../../docs/clang-tidy/checks/list.rst C:\_work\llvm-project\llvm-project\build\tools\clang\tools\extra\test\clang-tidy\infrastructure\Output\update-checks-list.test.tmp.clang-tidy-checks-list.rst
# executed command: diff --strip-trailing-cr 'C:\_work\llvm-project\llvm-project\clang-tools-extra\test\clang-tidy\infrastructure/../../../docs/clang-tidy/checks/list.rst' 'C:\_work\llvm-project\llvm-project\build\tools\clang\tools\extra\test\clang-tidy\infrastructure\Output\update-checks-list.test.tmp.clang-tidy-checks-list.rst'
# .---command stdout------------
# | *** C:\_work\llvm-project\llvm-project\clang-tools-extra\test\clang-tidy\infrastructure/../../../docs/clang-tidy/checks/list.rst
# | --- C:\_work\llvm-project\llvm-project\build\tools\clang\tools\extra\test\clang-tidy\infrastructure\Output\update-checks-list.test.tmp.clang-tidy-checks-list.rst
# | ***************
# | *** 76,96 ****
# |      :doc:`android-cloexec-pipe2 <android/cloexec-pipe2>`, "Yes"
# |      :doc:`android-cloexec-socket <android/cloexec-socket>`, "Yes"
# |      :doc:`android-comparison-in-temp-failure-retry <android/comparison-in-temp-failure-retry>`,
# |      :doc:`bugprone-argument-comment <bugprone/argument-comment>`, "Yes"
# | !    :doc:`boost-use-ranges <boost/use-ranges>`, "Yes"
# |      :doc:`bugprone-assignment-in-if-condition <bugprone/assignment-in-if-condition>`,
# | -    :doc:`boost-use-to-string <boost/use-to-string>`, "Yes"
# | -    :doc:`bugprone-assert-side-effect <bugprone/assert-side-effect>`,
# |      :doc:`bugprone-assignment-in-selection-statement <bugprone/assignment-in-selection-statement>`,
# |      :doc:`bugprone-bitwise-pointer-cast <bugprone/bitwise-pointer-cast>`,
# |      :doc:`bugprone-bool-pointer-implicit-conversion <bugprone/bool-pointer-implicit-conversion>`, "Yes"
# |      :doc:`bugprone-branch-clone <bugprone/branch-clone>`,
# | -    :doc:`bugprone-bad-signal-to-kill-thread <bugprone/bad-signal-to-kill-thread>`,
# |      :doc:`bugprone-capturing-this-in-member-variable <bugprone/capturing-this-in-member-variable>`,
# |      :doc:`bugprone-chained-comparison <bugprone/chained-comparison>`,
# | !    :doc:`bugprone-casting-through-void <bugprone/casting-through-void>`,
# |      :doc:`bugprone-compare-pointer-to-member-virtual-function <bugprone/compare-pointer-to-member-virtual-function>`,
# | -    :doc:`bugprone-command-processor <bugprone/command-processor>`,
# |      :doc:`bugprone-copy-constructor-init <bugprone/copy-constructor-init>`, "Yes"
# |      :doc:`bugprone-copy-constructor-mutates-argument <bugprone/copy-constructor-mutates-argument>`,
# |      :doc:`bugprone-crtp-constructor-accessibility <bugprone/crtp-constructor-accessibility>`, "Yes"
# | --- 76,96 ----
# |      :doc:`android-cloexec-pipe2 <android/cloexec-pipe2>`, "Yes"
# |      :doc:`android-cloexec-socket <android/cloexec-socket>`, "Yes"
# |      :doc:`android-comparison-in-temp-failure-retry <android/comparison-in-temp-failure-retry>`,
# | +    :doc:`boost-use-ranges <boost/use-ranges>`, "Yes"
# | +    :doc:`boost-use-to-string <boost/use-to-string>`, "Yes"
# |      :doc:`bugprone-argument-comment <bugprone/argument-comment>`, "Yes"
# | !    :doc:`bugprone-assert-side-effect <bugprone/assert-side-effect>`,
# |      :doc:`bugprone-assignment-in-if-condition <bugprone/assignment-in-if-condition>`,
# |      :doc:`bugprone-assignment-in-selection-statement <bugprone/assignment-in-selection-statement>`,
# | +    :doc:`bugprone-bad-signal-to-kill-thread <bugprone/bad-signal-to-kill-thread>`,
# |      :doc:`bugprone-bitwise-pointer-cast <bugprone/bitwise-pointer-cast>`,
# |      :doc:`bugprone-bool-pointer-implicit-conversion <bugprone/bool-pointer-implicit-conversion>`, "Yes"
# |      :doc:`bugprone-branch-clone <bugprone/branch-clone>`,
# |      :doc:`bugprone-capturing-this-in-member-variable <bugprone/capturing-this-in-member-variable>`,
# | +    :doc:`bugprone-casting-through-void <bugprone/casting-through-void>`,
# |      :doc:`bugprone-chained-comparison <bugprone/chained-comparison>`,
# | !    :doc:`bugprone-command-processor <bugprone/command-processor>`,
# |      :doc:`bugprone-compare-pointer-to-member-virtual-function <bugprone/compare-pointer-to-member-virtual-function>`,
# |      :doc:`bugprone-copy-constructor-init <bugprone/copy-constructor-init>`, "Yes"
# |      :doc:`bugprone-copy-constructor-mutates-argument <bugprone/copy-constructor-mutates-argument>`,
# |      :doc:`bugprone-crtp-constructor-accessibility <bugprone/crtp-constructor-accessibility>`, "Yes"
# | ***************
# | *** 99,112 ****
# |      :doc:`bugprone-derived-method-shadowing-base-method <bugprone/derived-method-shadowing-base-method>`,
# |      :doc:`bugprone-dynamic-static-initializers <bugprone/dynamic-static-initializers>`,
# |      :doc:`bugprone-easily-swappable-parameters <bugprone/easily-swappable-parameters>`,
# |      :doc:`bugprone-exception-copy-constructor-throws <bugprone/exception-copy-constructor-throws>`,
# |      :doc:`bugprone-exception-escape <bugprone/exception-escape>`,
# |      :doc:`bugprone-float-loop-counter <bugprone/float-loop-counter>`,
# | -    :doc:`bugprone-empty-catch <bugprone/empty-catch>`,
# |      :doc:`bugprone-fold-init-type <bugprone/fold-init-type>`,
# |      :doc:`bugprone-forward-declaration-namespace <bugprone/forward-declaration-namespace>`,
# |      :doc:`bugprone-forwarding-reference-overload <bugprone/forwarding-reference-overload>`,
# | !    :doc:`bugprone-implicit-widening-of-multiplication-result <bugprone/implicit-widening-of-multiplication-result>`
# |      :doc:`bugprone-inaccurate-erase <bugprone/inaccurate-erase>`, "Yes"
# |      :doc:`bugprone-inc-dec-in-conditions <bugprone/inc-dec-in-conditions>`,
# |      :doc:`bugprone-incorrect-enable-if <bugprone/incorrect-enable-if>`, "Yes"
# | --- 99,112 ----
# |      :doc:`bugprone-derived-method-shadowing-base-method <bugprone/derived-method-shadowing-base-method>`,
# |      :doc:`bugprone-dynamic-static-initializers <bugprone/dynamic-static-initializers>`,
# |      :doc:`bugprone-easily-swappable-parameters <bugprone/easily-swappable-parameters>`,
# | +    :doc:`bugprone-empty-catch <bugprone/empty-catch>`,
# |      :doc:`bugprone-exception-copy-constructor-throws <bugprone/exception-copy-constructor-throws>`,
# |      :doc:`bugprone-exception-escape <bugprone/exception-escape>`,
# |      :doc:`bugprone-float-loop-counter <bugprone/float-loop-counter>`,
# |      :doc:`bugprone-fold-init-type <bugprone/fold-init-type>`,
# |      :doc:`bugprone-forward-declaration-namespace <bugprone/forward-declaration-namespace>`,
# |      :doc:`bugprone-forwarding-reference-overload <bugprone/forwarding-reference-overload>`,
# | !    :doc:`bugprone-implicit-widening-of-multiplication-result <bugprone/implicit-widening-of-multiplication-result>`, "Yes"
# |      :doc:`bugprone-inaccurate-erase <bugprone/inaccurate-erase>`, "Yes"
# |      :doc:`bugprone-inc-dec-in-conditions <bugprone/inc-dec-in-conditions>`,
# |      :doc:`bugprone-incorrect-enable-if <bugprone/incorrect-enable-if>`, "Yes"
# `-----------------------------
# error: command failed with exit status: 1

--

```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/193134