[clang-tools-extra] [clang-tidy] Add `modernize-use-if-consteval` check (PR #189743)

[Yanzuo Liu via cfe-commits]

================
@@ -0,0 +1,150 @@
+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "UseIfConstevalCheck.h"
+
+#include "../utils/BracesAroundStatement.h"
+#include "clang/ASTMatchers/ASTMatchFinder.h"
+#include "clang/Basic/CharInfo.h"
+#include "clang/Lex/Lexer.h"
+
+using namespace clang::ast_matchers;
+
+namespace clang::tidy::modernize {
+
+namespace {
+
+struct BraceFix {
+  bool NeedsBraces = false;
+  utils::BraceInsertionHints Hints;
+};
+
+} // namespace
+
+static const Stmt *ignoreAttributedStmt(const Stmt *S) {
+  while (const auto *AS = dyn_cast_or_null<AttributedStmt>(S))
+    S = AS->getSubStmt();
+  return S;
+}
+
+static std::optional<CharSourceRange>
+getHeaderRange(const IfStmt *If, const SourceManager &SM,
+               const LangOptions &LangOpts) {
+  if (If->getLParenLoc().isMacroID() || If->getRParenLoc().isMacroID())
+    return std::nullopt;
+
+  const CharSourceRange HeaderRange = Lexer::makeFileCharRange(
+      CharSourceRange::getTokenRange(If->getLParenLoc(), If->getRParenLoc()),
+      SM, LangOpts);
+  if (HeaderRange.isInvalid())
+    return std::nullopt;
+  return HeaderRange;
+}
+
+static std::optional<BraceFix>
+getBraceFix(const Stmt *S, const LangOptions &LangOpts, const SourceManager &SM,
+            SourceLocation StartLoc,
+            SourceLocation EndLocHint = SourceLocation()) {
+  S = ignoreAttributedStmt(S);
+  if (!S || isa<CompoundStmt>(S))
+    return BraceFix();
+
+  const auto Hints =
+      utils::getBraceInsertionsHints(S, LangOpts, SM, StartLoc, EndLocHint);
+  if (!Hints || !Hints.offersFixIts())
+    return std::nullopt;
+
+  return BraceFix{true, Hints};
+}
+
+static bool needsLeadingSpaceBeforeConsteval(SourceLocation LParenLoc,
----------------
zwuis wrote:

I'm sorry that I forgot this case. It's up to you to use `getIfLoc` or `getLParenLoc`.

https://github.com/llvm/llvm-project/pull/189743