[clang-tools-extra] [clang-tidy][NFC] Add test case confirming #190944 is fixed (PR #192707)
Victor Chernyakin via cfe-commits
cfe-commits at lists.llvm.org
Fri Apr 17 18:51:25 PDT 2026
https://github.com/localspook updated https://github.com/llvm/llvm-project/pull/192707
>From 6f3ec7af6b9a0c306436daac81537459d8ec24f7 Mon Sep 17 00:00:00 2001
From: Victor Chernyakin <chernyakin.victor.j at outlook.com>
Date: Fri, 17 Apr 2026 10:49:15 -0700
Subject: [PATCH 1/2] [clang-tidy][NFC] Add test case confirming #190944 is
fixed
---
.../checkers/readability/redundant-typename.cpp | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/clang-tools-extra/test/clang-tidy/checkers/readability/redundant-typename.cpp b/clang-tools-extra/test/clang-tidy/checkers/readability/redundant-typename.cpp
index 56ff9813cd6ae..6a3745ea36d64 100644
--- a/clang-tools-extra/test/clang-tidy/checkers/readability/redundant-typename.cpp
+++ b/clang-tools-extra/test/clang-tidy/checkers/readability/redundant-typename.cpp
@@ -366,3 +366,15 @@ typename T::R Foo::PartiallySpecializedDataMember<T, typename T::V> = false;
// CHECK-FIXES-20: T::R Foo::PartiallySpecializedDataMember<T, typename T::V> = false;
#endif // __cplusplus >= 201402L
+
+struct Int {
+ using R = int;
+};
+
+template <typename T>
+struct BaseClass {};
+
+template <typename T>
+struct SubClass : BaseClass</* This used to be a false positive. */ typename T::R> {};
+
+template struct SubClass<Int>;
>From 526deb1ec0603200a1d9ce700f70c7ef2ff7c4cc Mon Sep 17 00:00:00 2001
From: Victor Chernyakin <chernyakin.victor.j at outlook.com>
Date: Fri, 17 Apr 2026 18:51:17 -0700
Subject: [PATCH 2/2] Remove comment
---
.../test/clang-tidy/checkers/readability/redundant-typename.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/clang-tools-extra/test/clang-tidy/checkers/readability/redundant-typename.cpp b/clang-tools-extra/test/clang-tidy/checkers/readability/redundant-typename.cpp
index 6a3745ea36d64..e2be40530865f 100644
--- a/clang-tools-extra/test/clang-tidy/checkers/readability/redundant-typename.cpp
+++ b/clang-tools-extra/test/clang-tidy/checkers/readability/redundant-typename.cpp
@@ -375,6 +375,6 @@ template <typename T>
struct BaseClass {};
template <typename T>
-struct SubClass : BaseClass</* This used to be a false positive. */ typename T::R> {};
+struct SubClass : BaseClass<typename T::R> {};
template struct SubClass<Int>;
More information about the cfe-commits
mailing list