[clang] [clang][ASTImporter] Remove 'hasReturnTypeDeclaredInside' (PR #169504)

[Donát Nagy via cfe-commits]

https://github.com/NagyDonat approved this pull request.

Thanks for testing the effects of this change!

Now that I also examined https://github.com/llvm/llvm-project/pull/162514/changes I can give a tentative "looks good to me", I'm convinced that this change is a good approach and a significant step forward. (In general I like the approach where that commit just sets up a general-purpose cycle detection instead of searching around for more concrete specialized information.)

However, I also noticed that there is a comment block which was extended by https://github.com/llvm/llvm-project/pull/162514 and should be updated in this PR now that you remove the old logic.

It would be nice to get another approval from somebody who is more familiar with the ASTImport procedure, but I think you can merge this if you update that comment and nobody objects within 1 week (until the 24th of April).


https://github.com/llvm/llvm-project/pull/169504