[clang] [llvm] [mlir] [Draft] Enforce single-operand node for distribute.enable (PR #192456)

[via cfe-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- clang/lib/CodeGen/CGLoopInfo.cpp clang/test/CodeGenCXX/pragma-followup_inner.cpp clang/test/CodeGenCXX/pragma-followup_outer.cpp clang/test/CodeGenCXX/pragma-loop-distribute.cpp clang/test/CodeGenCXX/pragma-loop.cpp llvm/lib/Analysis/LoopAccessAnalysis.cpp llvm/lib/Transforms/Scalar/LoopDistribute.cpp llvm/lib/Transforms/Utils/LoopConstrainer.cpp llvm/lib/Transforms/Utils/LoopUtils.cpp llvm/unittests/Analysis/LoopInfoTest.cpp mlir/lib/Target/LLVMIR/LoopAnnotationImporter.cpp mlir/lib/Target/LLVMIR/LoopAnnotationTranslation.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/lib/CodeGen/CGLoopInfo.cpp b/clang/lib/CodeGen/CGLoopInfo.cpp
index 8961db50f..925107977 100644
--- a/clang/lib/CodeGen/CGLoopInfo.cpp
+++ b/clang/lib/CodeGen/CGLoopInfo.cpp
@@ -334,12 +334,9 @@ LoopInfo::createLoopDistributeMetadata(const LoopAttributes &Attrs,
   if (Enabled != true) {
     SmallVector<Metadata *, 4> NewLoopProperties;
     if (Enabled == false) {
-      NewLoopProperties.append(
-          LoopProperties.begin(), LoopProperties.end());
+      NewLoopProperties.append(LoopProperties.begin(), LoopProperties.end());
       NewLoopProperties.push_back(MDNode::get(
-          Ctx,
-          {MDString::get(
-              Ctx, "llvm.loop.distribute.disable")}));
+          Ctx, {MDString::get(Ctx, "llvm.loop.distribute.disable")}));
       LoopProperties = NewLoopProperties;
     }
     return createLoopVectorizeMetadata(Attrs, LoopProperties,
@@ -348,15 +345,13 @@ LoopInfo::createLoopDistributeMetadata(const LoopAttributes &Attrs,
 
   bool FollowupHasTransforms = false;
   SmallVector<Metadata *, 4> Followup =
-      createLoopVectorizeMetadata(
-          Attrs, LoopProperties, FollowupHasTransforms);
+      createLoopVectorizeMetadata(Attrs, LoopProperties, FollowupHasTransforms);
 
   SmallVector<Metadata *, 4> Args;
   Args.append(LoopProperties.begin(), LoopProperties.end());
 
-  Args.push_back(MDNode::get(
-      Ctx,
-      {MDString::get(Ctx, "llvm.loop.distribute.enable")}));
+  Args.push_back(
+      MDNode::get(Ctx, {MDString::get(Ctx, "llvm.loop.distribute.enable")}));
 
   if (FollowupHasTransforms)
     Args.push_back(
diff --git a/llvm/lib/Analysis/LoopAccessAnalysis.cpp b/llvm/lib/Analysis/LoopAccessAnalysis.cpp
index ca5354930..2b5fb8154 100644
--- a/llvm/lib/Analysis/LoopAccessAnalysis.cpp
+++ b/llvm/lib/Analysis/LoopAccessAnalysis.cpp
@@ -2902,8 +2902,7 @@ void LoopAccessInfo::emitUnsafeDependenceRemark() {
 
   // Emit remark for first unsafe dependence
   bool HasForcedDistribution =
-      getBooleanLoopAttribute(
-          TheLoop, "llvm.loop.distribute.enable");
+      getBooleanLoopAttribute(TheLoop, "llvm.loop.distribute.enable");
 
   const std::string Info =
       HasForcedDistribution
diff --git a/llvm/lib/Transforms/Scalar/LoopDistribute.cpp b/llvm/lib/Transforms/Scalar/LoopDistribute.cpp
index 006cc43de..e5e235e18 100644
--- a/llvm/lib/Transforms/Scalar/LoopDistribute.cpp
+++ b/llvm/lib/Transforms/Scalar/LoopDistribute.cpp
@@ -940,8 +940,7 @@ private:
   void setForced() {
     if (getBooleanLoopAttribute(L, "llvm.loop.distribute.enable"))
       IsForced = true;
-    else if (getBooleanLoopAttribute(
-                 L, "llvm.loop.distribute.disable"))
+    else if (getBooleanLoopAttribute(L, "llvm.loop.distribute.disable"))
       IsForced = false;
   }
 
diff --git a/llvm/lib/Transforms/Utils/LoopConstrainer.cpp b/llvm/lib/Transforms/Utils/LoopConstrainer.cpp
index 74cd2a729..58ebd0e5e 100644
--- a/llvm/lib/Transforms/Utils/LoopConstrainer.cpp
+++ b/llvm/lib/Transforms/Utils/LoopConstrainer.cpp
@@ -452,9 +452,7 @@ static void DisableAllLoopOptsOnLoop(Loop &L) {
   MDNode *DisableLICMVersioning = MDNode::get(
       Context, {MDString::get(Context, "llvm.loop.licm_versioning.disable")});
   MDNode *DisableDistribution = MDNode::get(
-      Context,
-      {MDString::get(
-          Context, "llvm.loop.distribute.disable")});
+      Context, {MDString::get(Context, "llvm.loop.distribute.disable")});
   MDNode *NewLoopID =
       MDNode::get(Context, {Dummy, DisableUnroll, DisableVectorize,
                             DisableLICMVersioning, DisableDistribution});
diff --git a/mlir/lib/Target/LLVMIR/LoopAnnotationImporter.cpp b/mlir/lib/Target/LLVMIR/LoopAnnotationImporter.cpp
index 4022afc43..fcb11ca46 100644
--- a/mlir/lib/Target/LLVMIR/LoopAnnotationImporter.cpp
+++ b/mlir/lib/Target/LLVMIR/LoopAnnotationImporter.cpp
@@ -359,8 +359,7 @@ FailureOr<LoopLICMAttr> LoopMetadataConversion::convertLICMAttr() {
 
 FailureOr<LoopDistributeAttr> LoopMetadataConversion::convertDistributeAttr() {
   FailureOr<BoolAttr> disable = lookupBooleanUnitNode(
-      "llvm.loop.distribute.enable",
-      "llvm.loop.distribute.disable",
+      "llvm.loop.distribute.enable", "llvm.loop.distribute.disable",
       /*negated=*/true);
   FailureOr<LoopAnnotationAttr> followupCoincident =
       lookupFollowupNode("llvm.loop.distribute.followup_coincident");

``````````

</details>


https://github.com/llvm/llvm-project/pull/192456