[clang] [Clang] diagnosing missing Vulkan environment when using SPIR-V triple (PR #190840)

[via cfe-commits]

================
@@ -112,6 +112,18 @@ void CompilerInstance::setTarget(TargetInfo *Value) { Target = Value; }
 void CompilerInstance::setAuxTarget(TargetInfo *Value) { AuxTarget = Value; }
 
 bool CompilerInstance::createTarget() {
+
+  // SPIR-V targeting requires a fully specified Vulkan environment.
+  // Validate here before CreateTargetInfo() to emit a proper diagnostic
+  llvm::Triple Triple(getInvocation().getTargetOpts().Triple);
----------------
PrabbyDD wrote:

Ah the meeting closed...I was going to ask if that means I should make a validateTarget function or if this location is good for now? And if this location is still fine then I should still move it after the !hasTarget check like Tony mentioned? 

https://github.com/llvm/llvm-project/pull/190840