[clang] [clang][analyzer] Add support for detecting uninitialized union fields (PR #191812)

[via cfe-commits]

=?utf-8?b?8J+NjFNoYXdu?= <m18824909883 at 163.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/191812 at github.com>


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- clang/test/Analysis/cxx-uninitialized-object-union-field.cpp clang/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObjectChecker.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObjectChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObjectChecker.cpp
index a98b2d7f5..eb520215a 100644
--- a/clang/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObjectChecker.cpp
+++ b/clang/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObjectChecker.cpp
@@ -374,9 +374,9 @@ bool FindUninitializedFields::isNonUnionUninit(const TypedValueRegion *R,
 bool FindUninitializedFields::isUnionUninit(const TypedValueRegion *R) {
   assert(R->getValueType()->isUnionType() &&
          "This method only checks union objects!");
-    
+
   const RecordDecl *RD = R->getValueType()->getAsRecordDecl()->getDefinition();
-   
+
   if (!RD)
     return false;
 
@@ -387,7 +387,8 @@ bool FindUninitializedFields::isUnionUninit(const TypedValueRegion *R) {
     if (FD->isUnnamedBitField())
       continue;
 
-    const auto FieldVal = State->getLValue(FD, loc::MemRegionVal(R)).castAs<loc::MemRegionVal>();
+    const auto FieldVal =
+        State->getLValue(FD, loc::MemRegionVal(R)).castAs<loc::MemRegionVal>();
     SVal V = State->getSVal(FieldVal);
 
     // If any field has a defined value, the union is initialized.

``````````

</details>


https://github.com/llvm/llvm-project/pull/191812