[clang] [LifetimeSafety] Detect use-after-scope through fields in member calls (PR #191731)

[Utkarsh Saxena via cfe-commits]

================
@@ -723,6 +723,19 @@ void FactsGenerator::handleInvalidatingCall(const Expr *Call,
         ThisList->getOuterOriginID(), Call));
 }
 
+void FactsGenerator::handleImplicitObjectFieldUses(const Expr *Call,
+                                                   const FunctionDecl *FD) {
+  const auto *MD = dyn_cast<CXXMethodDecl>(FD);
+  if (!MD || !MD->isInstance())
+    return;
+
+  for (const auto *Field : MD->getParent()->fields()) {
+    OriginList *FieldList = getOriginsList(*Field);
+    if (FieldList)
----------------
usx95 wrote:

nit: inline the assignment in `if`.

`if(OriginList *FieldList = getOriginsList(*Field))`

(then remove the braces of `for`).

https://github.com/llvm/llvm-project/pull/191731