[clang] [clang-format] Remove special handling of comments after brace/paren (PR #71672)
Björn Schäpers via cfe-commits
cfe-commits at lists.llvm.org
Sat Apr 11 15:51:21 PDT 2026
================
@@ -925,7 +925,12 @@ void ContinuationIndenter::addTokenOnCurrentLine(LineState &State, bool DryRun,
TT_TableGenDAGArgOpenerToBreak) &&
!(Current.MacroParent && Previous.MacroParent) &&
(Current.isNot(TT_LineComment) ||
- Previous.isOneOf(BK_BracedInit, TT_VerilogMultiLineListLParen)) &&
+ (Previous.is(BK_BracedInit) &&
+ (Style.Cpp11BracedListStyle != FormatStyle::BLS_FunctionCall ||
+ !Previous.Previous ||
+ Previous.Previous->isNoneOf(tok::identifier, tok::l_paren,
----------------
HazardyKnusperkeks wrote:
And we only land here if `FunctionCall` is configured, otherwise `Style.Cpp11BracedListStyle != FormatStyle::BLS_FunctionCall` is true.
And before this patch `Cpp11BracedListStyle` had no effect on this whole `if`.
What's the point you want to make? It's more than half a year, I can't remember all the details or my reasoning here. It fixed the issue and aligned the (tested) implementation with the documentation, is there something wrong, or that bothers you?
https://github.com/llvm/llvm-project/pull/71672
More information about the cfe-commits
mailing list