[clang] [Clang] Track constraint's SubstIndex only if it contains outer parameter packs (PR #191484)

[Corentin Jabot via cfe-commits]

================
@@ -493,12 +493,6 @@ class ConstraintSatisfactionChecker {
       CachedTemplateArgs;
 
 private:
-  template <class Constraint>
-  UnsignedOrNone getOuterPackIndex(const Constraint &C) const {
-    return C.getPackSubstitutionIndex() ? C.getPackSubstitutionIndex()
-                                        : PackSubstitutionIndex;
-  }
----------------
cor3ntin wrote:

We do that a couple of times so I think we should keep the function

https://github.com/llvm/llvm-project/pull/191484